Changeset 50689 for trunk/src/wp-admin/includes/dashboard.php

Timestamp:

04/07/2021 06:32:01 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in wp-admin/includes/dashboard.php.

Includes minor code layout fixes for better readability.

See #52627.

File:

• trunk/src/wp-admin/includes/dashboard.php (modified) (35 diffs)

trunk/src/wp-admin/includes/dashboard.php

@@ -20 +20 @@
 function wp_dashboard_setup() {
     global $wp_registered_widgets, $wp_registered_widget_controls, $wp_dashboard_control_callbacks;
+
     $wp_dashboard_control_callbacks = array();
     $screen                         = get_current_screen();
@@ -29 +30 @@
     if ( $response && $response['upgrade'] ) {
         add_filter( 'postbox_classes_dashboard_dashboard_browser_nag', 'dashboard_browser_nag_class' );
+
         if ( $response['insecure'] ) {
             wp_add_dashboard_widget( 'dashboard_browser_nag', __( 'You are using an insecure browser!' ), 'wp_dashboard_browser_nag' );
@@ -38 +40 @@
     // PHP Version.
     $response = wp_check_php_version();
-    if ( $response && isset( $response['is_acceptable'] ) && ! $response['is_acceptable'] && current_user_can( 'update_php' ) ) {
+
+    if ( $response && isset( $response['is_acceptable'] ) && ! $response['is_acceptable']
+        && current_user_can( 'update_php' )
+    ) {
         add_filter( 'postbox_classes_dashboard_dashboard_php_nag', 'dashboard_php_nag_class' );
+
         wp_add_dashboard_widget( 'dashboard_php_nag', __( 'PHP Update Recommended' ), 'wp_dashboard_php_nag' );
     }
@@ -175 +181 @@
  */
 function wp_add_dashboard_widget( $widget_id, $widget_name, $callback, $control_callback = null, $callback_args = null, $context = 'normal', $priority = 'core' ) {
+    global $wp_dashboard_control_callbacks;
+
     $screen = get_current_screen();
-    global $wp_dashboard_control_callbacks;
 
     $private_callback_args = array( '__widget_basename' => $widget_name );
@@ -186 +193 @@
     }
 
-    if ( $control_callback && current_user_can( 'edit_dashboard' ) && is_callable( $control_callback ) ) {
+    if ( $control_callback && is_callable( $control_callback ) && current_user_can( 'edit_dashboard' ) ) {
         $wp_dashboard_control_callbacks[ $widget_id ] = $control_callback;
-        if ( isset( $_GET['edit'] ) && $widget_id == $_GET['edit'] ) {
+
+        if ( isset( $_GET['edit'] ) && $widget_id === $_GET['edit'] ) {
             list($url)    = explode( '#', add_query_arg( 'edit', false ), 2 );
             $widget_name .= ' <span class="postbox-title-action"><a href="' . esc_url( $url ) . '">' . __( 'Cancel' ) . '</a></span>';
@@ -213 +221 @@
         $context = 'normal';
     }
+
     if ( empty( $priority ) ) {
         $priority = 'core';
@@ -247 +256 @@
     $columns     = absint( $screen->get_columns() );
     $columns_css = '';
+
     if ( $columns ) {
         $columns_css = " columns-$columns";
     }
-
     ?>
 <div id="dashboard-widgets" class="metabox-holder<?php echo $columns_css; ?>">
@@ -292 +301 @@
     foreach ( array( 'post', 'page' ) as $post_type ) {
         $num_posts = wp_count_posts( $post_type );
+
         if ( $num_posts && $num_posts->publish ) {
             if ( 'post' === $post_type ) {
@@ -300 +310 @@
                 $text = _n( '%s Page', '%s Pages', $num_posts->publish );
             }
+
             $text             = sprintf( $text, number_format_i18n( $num_posts->publish ) );
             $post_type_object = get_post_type_object( $post_type );
+
             if ( $post_type_object && current_user_can( $post_type_object->cap->edit_posts ) ) {
                 printf( '<li class="%1$s-count"><a href="edit.php?post_type=%1$s">%2$s</a></li>', $post_type, $text );
@@ -309 +321 @@
         }
     }
+
     // Comments.
     $num_comm = wp_count_comments();
+
     if ( $num_comm && ( $num_comm->approved || $num_comm->moderated ) ) {
         /* translators: %s: Number of comments. */
         $text = sprintf( _n( '%s Comment', '%s Comments', $num_comm->approved ), number_format_i18n( $num_comm->approved ) );
         ?>
-        <li class="comment-count"><a href="edit-comments.php"><?php echo $text; ?></a></li>
+        <li class="comment-count">
+            <a href="edit-comments.php"><?php echo $text; ?></a>
+        </li>
         <?php
         $moderated_comments_count_i18n = number_format_i18n( $num_comm->moderated );
@@ -321 +337 @@
         $text = sprintf( _n( '%s Comment in moderation', '%s Comments in moderation', $num_comm->moderated ), $moderated_comments_count_i18n );
         ?>
-        <li class="comment-mod-count
-        <?php
-        if ( ! $num_comm->moderated ) {
-            echo ' hidden';
-        }
-        ?>
-        "><a href="edit-comments.php?comment_status=moderated" class="comments-in-moderation-text"><?php echo $text; ?></a></li>
+        <li class="comment-mod-count<?php echo ! $num_comm->moderated ? ' hidden' : ''; ?>">
+            <a href="edit-comments.php?comment_status=moderated" class="comments-in-moderation-text"><?php echo $text; ?></a>
+        </li>
         <?php
     }
@@ -354 +366 @@
 
     // Check if search engines are asked not to index this site.
-    if ( ! is_network_admin() && ! is_user_admin() && current_user_can( 'manage_options' ) && '0' == get_option( 'blog_public' ) ) {
+    if ( ! is_network_admin() && ! is_user_admin()
+        && current_user_can( 'manage_options' ) && ! get_option( 'blog_public' )
+    ) {
 
         /**
@@ -379 +393 @@
          * @param string $content Default text.
          */
-        $content    = apply_filters( 'privacy_on_link_text', __( 'Search engines discouraged' ) );
+        $content = apply_filters( 'privacy_on_link_text', __( 'Search engines discouraged' ) );
+
         $title_attr = '' === $title ? '' : " title='$title'";
 
@@ -427 +442 @@
 function wp_network_dashboard_right_now() {
     $actions = array();
+
     if ( current_user_can( 'create_sites' ) ) {
         $actions['create-site'] = '<a href="' . network_admin_url( 'site-new.php' ) . '">' . __( 'Create a New Site' ) . '</a>';
@@ -516 +532 @@
     }
 
-    /* Check if a new auto-draft (= no new post_ID) is needed or if the old can be used */
+    // Check if a new auto-draft (= no new post_ID) is needed or if the old can be used.
     $last_post_id = (int) get_user_option( 'dashboard_quick_press_last_post_id' ); // Get the last post_ID.
+
     if ( $last_post_id ) {
         $post = get_post( $last_post_id );
+
         if ( empty( $post ) || 'auto-draft' !== $post->post_status ) { // auto-draft doesn't exist anymore.
             $post = get_default_post_to_edit( 'post', true );
@@ -529 +547 @@
         $post    = get_default_post_to_edit( 'post', true );
         $user_id = get_current_user_id();
+
         // Don't create an option if this is a super admin who does not belong to this site.
         if ( in_array( get_current_blog_id(), array_keys( get_blogs_of_user( $user_id ) ), true ) ) {
@@ -607 +626 @@
 
     echo '<div class="drafts">';
+
     if ( count( $drafts ) > 3 ) {
         printf(
@@ -614 +634 @@
         );
     }
-    echo '<h2 class="hide-if-no-js">' . __( 'Your Recent Drafts' ) . "</h2>\n<ul>";
+
+    echo '<h2 class="hide-if-no-js">' . __( 'Your Recent Drafts' ) . "</h2>\n";
+    echo '<ul>';
 
     /* translators: Maximum number of words used in a preview of a draft on the dashboard. */
@@ -623 +645 @@
         $url   = get_edit_post_link( $draft->ID );
         $title = _draft_or_post_title( $draft->ID );
+
         echo "<li>\n";
         printf(
@@ -633 +656 @@
             get_the_time( __( 'F j, Y' ), $draft )
         );
+
         $the_content = wp_trim_words( $draft->post_content, $draft_length );
+
         if ( $the_content ) {
             echo '<p>' . $the_content . '</p>';
@@ -639 +664 @@
         echo "</li>\n";
     }
-    echo "</ul>\n</div>";
+
+    echo "</ul>\n";
+    echo '</div>';
 }
 
@@ -657 +684 @@
 
     if ( $comment->comment_post_ID > 0 ) {
-
         $comment_post_title = _draft_or_post_title( $comment->comment_post_ID );
         $comment_post_url   = get_the_permalink( $comment->comment_post_ID );
@@ -953 +979 @@
      */
     $query_args = apply_filters( 'dashboard_recent_posts_query_args', $query_args );
-    $posts      = new WP_Query( $query_args );
+
+    $posts = new WP_Query( $query_args );
 
     if ( $posts->have_posts() ) {
@@ -971 +998 @@
 
             $time = get_the_time( 'U' );
-            if ( gmdate( 'Y-m-d', $time ) == $today ) {
+
+            if ( gmdate( 'Y-m-d', $time ) === $today ) {
                 $relative = __( 'Today' );
-            } elseif ( gmdate( 'Y-m-d', $time ) == $tomorrow ) {
+            } elseif ( gmdate( 'Y-m-d', $time ) === $tomorrow ) {
                 $relative = __( 'Tomorrow' );
             } elseif ( gmdate( 'Y', $time ) !== $year ) {
@@ -1026 +1054 @@
         'offset' => 0,
     );
+
     if ( ! current_user_can( 'edit_posts' ) ) {
         $comments_query['status'] = 'approve';
@@ -1034 +1063 @@
             break;
         }
+
         foreach ( $possible as $comment ) {
             if ( ! current_user_can( 'read_post', $comment->comment_post_ID ) ) {
                 continue;
             }
+
             $comments[] = $comment;
-            if ( count( $comments ) == $total_items ) {
+
+            if ( count( $comments ) === $total_items ) {
                 break 2;
             }
         }
+
         $comments_query['offset'] += $comments_query['number'];
         $comments_query['number']  = $total_items * 10;
@@ -1110 +1143 @@
     if ( empty( $check_urls ) ) {
         $widgets = get_option( 'dashboard_widget_options' );
+
         if ( empty( $widgets[ $widget_id ]['url'] ) && ! $doing_ajax ) {
             echo $loading;
             return false;
         }
+
         $check_urls = array( $widgets[ $widget_id ]['url'] );
     }
@@ -1120 +1155 @@
     $cache_key = 'dash_v2_' . md5( $widget_id . '_' . $locale );
     $output    = get_transient( $cache_key );
+
     if ( false !== $output ) {
         echo $output;
@@ -1157 +1193 @@
     global $wp_dashboard_control_callbacks;
 
-    if ( is_scalar( $widget_control_id ) && $widget_control_id && isset( $wp_dashboard_control_callbacks[ $widget_control_id ] ) && is_callable( $wp_dashboard_control_callbacks[ $widget_control_id ] ) ) {
+    if ( is_scalar( $widget_control_id ) && $widget_control_id
+        && isset( $wp_dashboard_control_callbacks[ $widget_control_id ] )
+        && is_callable( $wp_dashboard_control_callbacks[ $widget_control_id ] )
+    ) {
         call_user_func(
             $wp_dashboard_control_callbacks[ $widget_control_id ],
@@ -1182 +1221 @@
 function wp_dashboard_rss_control( $widget_id, $form_inputs = array() ) {
     $widget_options = get_option( 'dashboard_widget_options' );
+
     if ( ! $widget_options ) {
         $widget_options = array();
@@ -1210 +1250 @@
             }
         }
+
         update_option( 'dashboard_widget_options', $widget_options );
+
         $locale    = get_user_locale();
         $cache_key = 'dash_v2_' . md5( $widget_id . '_' . $locale );
@@ -1555 +1597 @@
  */
 function wp_dashboard_quota() {
-    if ( ! is_multisite() || ! current_user_can( 'upload_files' ) || get_site_option( 'upload_space_check_disabled' ) ) {
+    if ( ! is_multisite() || ! current_user_can( 'upload_files' )
+        || get_site_option( 'upload_space_check_disabled' )
+    ) {
         return true;
     }
@@ -1567 +1611 @@
         $percentused = ( $used / $quota ) * 100;
     }
+
     $used_class  = ( $percentused >= 70 ) ? ' warning' : '';
     $used        = round( $used, 2 );
@@ -1704 +1749 @@
 
     $response = get_site_transient( 'browser_' . $key );
+
     if ( false === $response ) {
         // Include an unmodified $wp_version.
@@ -1720 +1766 @@
         $response = wp_remote_post( $url, $options );
 
-        if ( is_wp_error( $response ) || 200 != wp_remote_retrieve_response_code( $response ) ) {
+        if ( is_wp_error( $response ) || 200 !== wp_remote_retrieve_response_code( $response ) ) {
             return false;
         }