Changeset 50693

Timestamp:

04/09/2021 11:29:58 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Editor: Use a consistent way to retrieve post ID on Edit Post screens.

Props mukesh27, ravipatel, davidbaumwald.
Fixes #52995.

Location:

trunk/src/wp-admin

Files:

• edit-form-advanced.php (modified) (5 diffs)
• edit-form-blocks.php (modified) (1 diff)

trunk/src/wp-admin/edit-form-advanced.php

@@ -79 +79 @@
 $action  = isset( $action ) ? $action : '';
 
-if ( (int) get_option( 'page_for_posts' ) === $post_ID && empty( $post->post_content ) ) {
+if ( (int) get_option( 'page_for_posts' ) === $post->ID && empty( $post->post_content ) ) {
         add_action( 'edit_form_after_title', '_wp_posts_page_notice' );
         remove_post_type_support( $post_type, 'editor' );
@@ -95 +95 @@
 if ( $thumbnail_support ) {
         add_thickbox();
-        wp_enqueue_media( array( 'post' => $post_ID ) );
+        wp_enqueue_media( array( 'post' => $post->ID ) );
 }
 
@@ -104 +104 @@
  * @todo Document the $messages array(s).
  */
-$permalink = get_permalink( $post_ID );
+$permalink = get_permalink( $post->ID );
 if ( ! $permalink ) {
         $permalink = '';
@@ -238 +238 @@
         $form_extra .= "<input type='hidden' id='auto_draft' name='auto_draft' value='1' />";
 } else {
-        $autosave = wp_get_post_autosave( $post_ID );
+        $autosave = wp_get_post_autosave( $post->ID );
 }
 
 $form_action  = 'editpost';
-$nonce_action = 'update-post_' . $post_ID;
-$form_extra  .= "<input type='hidden' id='post_ID' name='post_ID' value='" . esc_attr( $post_ID ) . "' />";
+$nonce_action = 'update-post_' . $post->ID;
+$form_extra  .= "<input type='hidden' id='post_ID' name='post_ID' value='" . esc_attr( $post->ID ) . "' />";
 
 // Detect if there exists an autosave newer than the post and if that autosave is different than the post.
@@ -622 +622 @@
         if ( 'auto-draft' !== $post->post_status ) {
                 echo '<span id="last-edit">';
-                $last_user = get_userdata( get_post_meta( $post_ID, '_edit_last', true ) );
+                $last_user = get_userdata( get_post_meta( $post->ID, '_edit_last', true ) );
                 if ( $last_user ) {
                         /* translators: 1: Name of most recent post author, 2: Post edited date, 3: Post edited time. */

trunk/src/wp-admin/edit-form-blocks.php

@@ -347 +347 @@
 );
 
-$autosave = wp_get_post_autosave( $post_ID );
+$autosave = wp_get_post_autosave( $post->ID );
 if ( $autosave ) {
         if ( mysql2date( 'U', $autosave->post_modified_gmt, false ) > mysql2date( 'U', $post->post_modified_gmt, false ) ) {