Changeset 50713 for trunk/src/wp-admin/includes/privacy-tools.php

Timestamp:

04/14/2021 09:26:58 PM (4 years ago)

Author:

davidbaumwald

Message:

Privacy: Ensure "Export Personal Data" does not generate invalid JSON.

Previously, when exporting personal data, if the JSON encoding of the data failed, the invalid JSON was still written to export.json. This change captures the JSON encoding failure and adds a notice to the UI.

Props hellofromTonya, jrf, SergeyBiryukov.
Fixes #52892.

File:

• trunk/src/wp-admin/includes/privacy-tools.php (modified) (1 diff)

trunk/src/wp-admin/includes/privacy-tools.php

@@ -414 +414 @@
     $groups_json = wp_json_encode( $groups );
 
+    if ( false === $groups_json ) {
+        $error_message = sprintf(
+            /* translators: %s: Error message. */
+            __( 'Unable to encode the personal data for export. Error: %s' ),
+            json_last_error_msg()
+        );
+
+        wp_send_json_error( $error_message );
+    }
+
     /*
      * Handle the JSON export.