Changeset 50766

Timestamp:

04/17/2021 11:27:35 AM (4 years ago)

Author:

Clorith

Message:

Site Health: Remove Ajax requests from dashboard widget.

The Site Health dashboard widget uses the same JavaScript file as the Site Health pages to generate its progress indicator.

This file was also set up to store the current Site Health check results if the current tab being shown isn't the debug information one, this had the side effect of the dashboard being seen as not the debug screen as well.

This now has a conditional making sure it's the status screen it self being displayed, before trying to do any Ajax requests.

Props arena.
Fixes #49814.

Location:

trunk/src

Files:

• js/_enqueues/admin/site-health.js (modified) (3 diffs)
• wp-admin/site-health.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/site-health.js

@@ -13 +13 @@
         sprintf = wp.i18n.sprintf,
         clipboard = new ClipboardJS( '.site-health-copy-buttons .copy-button' ),
+        isStatusTab = $( '.health-check-body.health-check-status-tab' ).length,
         isDebugTab = $( '.health-check-body.health-check-debug-tab' ).length,
         pathsSizesSection = $( '#health-check-accordion-block-wp-paths-sizes' ),
@@ -230 +231 @@
         }
 
-        if ( ! isDebugTab ) {
+        if ( isStatusTab ) {
             $.post(
                 ajaxurl,
@@ -347 +348 @@
     }
 
-    if ( 'undefined' !== typeof SiteHealth && ! isDebugTab ) {
+    if ( 'undefined' !== typeof SiteHealth ) {
         if ( 0 === SiteHealth.site_status.direct.length && 0 === SiteHealth.site_status.async.length ) {
             recalculateProgression();

trunk/src/wp-admin/site-health.php

@@ -196 +196 @@
 </div>
 
-<div class="health-check-body hide-if-no-js">
+<div class="health-check-body health-check-status-tab hide-if-no-js">
     <div class="site-status-all-clear hide">
         <p class="icon">