Changeset 50777 for trunk/tests/phpunit/tests/blocks/block-editor.php

Timestamp:

04/21/2021 09:30:40 AM (5 years ago)

Author:

gziolo

Message:

Editor: Shape block editor filters to work better with the Gutenberg plugin

This should allow to use new filters in the Gutenberg plugin and therefore it prevents deprecation warnings when in the debug mode.

See #52920.

File:

• trunk/tests/phpunit/tests/blocks/block-editor.php (modified) (4 diffs)

trunk/tests/phpunit/tests/blocks/block-editor.php

@@ -253 +253 @@
             return array( 'test/filtered-my-block' );
         }
-        function filter_block_categories_my_editor() {
-            return array(
-                array(
-                    'slug'  => 'filtered-my-category',
-                    'title' => 'Filtered My Category',
-                    'icon'  => null,
-                ),
-            );
-        }
         function filter_block_editor_settings_my_editor( $editor_settings ) {
             $editor_settings['maxUploadFileSize'] = 12345;
@@ -269 +260 @@
 
         add_filter( 'allowed_block_types_my-editor', 'filter_allowed_block_types_my_editor', 10, 1 );
-        add_filter( 'block_categories_my-editor', 'filter_block_categories_my_editor', 10, 1 );
         add_filter( 'block_editor_settings_my-editor', 'filter_block_editor_settings_my_editor', 10, 1 );
 
@@ -275 +265 @@
 
         remove_filter( 'allowed_block_types_my-editor', 'filter_allowed_block_types_my_editor' );
-        remove_filter( 'block_categories_my-editor', 'filter_block_categories_my_editor' );
         remove_filter( 'block_editor_settings_my-editor', 'filter_block_editor_settings_my_editor' );
 
         $this->assertSameSets( array( 'test/filtered-my-block' ), $settings['allowedBlockTypes'] );
-        $this->assertSameSets(
-            array(
-                array(
-                    'slug'  => 'filtered-my-category',
-                    'title' => 'Filtered My Category',
+        $this->assertSame( 12345, $settings['maxUploadFileSize'] );
+    }
+
+    /**
+     * @ticket 52920
+     */
+    function test_get_block_editor_settings_overrides_default_settings_any_editor() {
+        function filter_allowed_block_types_any_editor() {
+            return array( 'test/filtered-any-block' );
+        }
+        function filter_block_categories_any_editor() {
+            return array(
+                array(
+                    'slug'  => 'filtered-any-category',
+                    'title' => 'Filtered Any Category',
+                    'icon'  => null,
+                ),
+            );
+        }
+        function filter_block_editor_settings_any_editor( $editor_settings ) {
+            $editor_settings['maxUploadFileSize'] = 54321;
+
+            return $editor_settings;
+        }
+
+        add_filter( 'allowed_block_types_all', 'filter_allowed_block_types_any_editor', 10, 1 );
+        add_filter( 'block_categories_all', 'filter_block_categories_any_editor', 10, 1 );
+        add_filter( 'block_editor_settings_all', 'filter_block_editor_settings_any_editor', 10, 1 );
+
+        $settings = get_block_editor_settings( 'any-editor' );
+
+        remove_filter( 'allowed_block_types_all', 'filter_allowed_block_types_any_editor' );
+        remove_filter( 'block_categories_all', 'filter_block_categories_any_editor' );
+        remove_filter( 'block_editor_settings_all', 'filter_block_editor_settings_any_editor' );
+
+        $this->assertSameSets( array( 'test/filtered-any-block' ), $settings['allowedBlockTypes'] );
+        $this->assertSameSets(
+            array(
+                array(
+                    'slug'  => 'filtered-any-category',
+                    'title' => 'Filtered Any Category',
                     'icon'  => null,
                 ),
@@ -289 +314 @@
             $settings['blockCategories']
         );
-        $this->assertSame( 12345, $settings['maxUploadFileSize'] );
+        $this->assertSame( 54321, $settings['maxUploadFileSize'] );
     }