Changeset 50814 for trunk/tests/phpunit/tests/functions.php

Timestamp:

05/05/2021 05:06:17 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Media: Some documentation and test improvements for WebP support:

• Document that WebP constants are only defined in PHP 7.1+.
• Correct the $filename parameter type in wp_get_webp_info().
• Use a consistent message when skipping tests due to the lack of WebP support.
• Remove unnecessary else branches after markTestSkipped().
• Replace assertEquals() with more appropriate assertions.

Follow-up to [50810].

See #35725.

File:

• trunk/tests/phpunit/tests/functions.php (modified) (3 diffs)

trunk/tests/phpunit/tests/functions.php

@@ -1241 +1241 @@
                 if ( is_array( $expected ) ) {
                         foreach ( $expected as $k => $v ) {
-                                $this->assertEquals( true, isset( $result[ $k ] ) );
-                                $this->assertEquals( $expected[ $k ], $result[ $k ] );
+                                $this->assertArrayHasKey( $k, $result );
+                                $this->assertSame( $expected[ $k ], $result[ $k ] );
                         }
                 } else {
-                        $this->assertEquals( $expected, $result );
+                        $this->assertSame( $expected, $result );
                 }
         }
@@ -1313 +1313 @@
 
         /**
-         * Data provider for test_wp_get_image_mime();
+         * Data provider for test_wp_get_image_mime().
          */
         public function _wp_get_image_mime() {
@@ -1368 +1368 @@
 
         /**
-         * Data profider for test_wp_getimagesize();
+         * Data profider for test_wp_getimagesize().
          */
         public function data_wp_getimagesize() {