Changeset 50814 for trunk/tests/phpunit/tests/image/editor.php

Timestamp:

05/05/2021 05:06:17 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Media: Some documentation and test improvements for WebP support:

• Document that WebP constants are only defined in PHP 7.1+.
• Correct the $filename parameter type in wp_get_webp_info().
• Use a consistent message when skipping tests due to the lack of WebP support.
• Remove unnecessary else branches after markTestSkipped().
• Replace assertEquals() with more appropriate assertions.

Follow-up to [50810].

See #35725.

File:

• trunk/tests/phpunit/tests/image/editor.php (modified) (1 diff)

trunk/tests/phpunit/tests/image/editor.php

@@ -206 +206 @@
     public function test_wp_get_webp_info( $file, $expected ) {
         $editor = wp_get_image_editor( $file );
+
         if ( is_wp_error( $editor ) || ! $editor->supports_mime_type( 'image/webp' ) ) {
-            $this->markTestSkipped( sprintf( 'Skipping test: no WebP support in the editor engine %s on this system.', $this->editor_engine ) );
-        } else {
-            $file_data = wp_get_webp_info( $file );
-            $this->assertSame( $file_data, $expected );
+            $this->markTestSkipped( sprintf( 'No WebP support in the editor engine %s on this system.', $this->editor_engine ) );
         }
-    }
-
-    /**
-     * Data provider for test_wp_get_webp_info();
+
+        $file_data = wp_get_webp_info( $file );
+        $this->assertSame( $file_data, $expected );
+    }
+
+    /**
+     * Data provider for test_wp_get_webp_info().
      */
     public function _test_wp_get_webp_info() {