Changeset 50814 for trunk/tests/phpunit/tests/image/resize.php

Timestamp:

05/05/2021 05:06:17 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Media: Some documentation and test improvements for WebP support:

• Document that WebP constants are only defined in PHP 7.1+.
• Correct the $filename parameter type in wp_get_webp_info().
• Use a consistent message when skipping tests due to the lack of WebP support.
• Remove unnecessary else branches after markTestSkipped().
• Replace assertEquals() with more appropriate assertions.

Follow-up to [50810].

See #35725.

File:

• trunk/tests/phpunit/tests/image/resize.php (modified) (1 diff)

trunk/tests/phpunit/tests/image/resize.php

@@ -71 +71 @@
         // Check if the editor supports the webp mime type.
         if ( is_wp_error( $editor ) || ! $editor->supports_mime_type( 'image/webp' ) ) {
-            $this->markTestSkipped( sprintf( 'Skipping test: no WebP support in the editor engine %s on this system.', $this->editor_engine ) );
-        } else {
-            $image = $this->resize_helper( $file, 25, 25 );
-            $this->assertSame( 'test-image-25x25.webp', wp_basename( $image ) );
-            list($w, $h, $type) = wp_getimagesize( $image );
-            $this->assertSame( 25, $w );
-            $this->assertSame( 25, $h );
-            $this->assertSame( IMAGETYPE_WEBP, $type );
-            unlink( $image );
-        }
+            $this->markTestSkipped( sprintf( 'No WebP support in the editor engine %s on this system.', $this->editor_engine ) );
+        }
+
+        $image = $this->resize_helper( $file, 25, 25 );
+        $this->assertSame( 'test-image-25x25.webp', wp_basename( $image ) );
+        list($w, $h, $type) = wp_getimagesize( $image );
+        $this->assertSame( 25, $w );
+        $this->assertSame( 25, $h );
+        $this->assertSame( IMAGETYPE_WEBP, $type );
+        unlink( $image );
     }