Changeset 50830

Timestamp:

05/07/2021 11:49:15 PM (3 years ago)

Author:

joedolson

Message:

Permalinks: Add labels for permalink configuration fields.

If the current server configuration doesn't allow WordPress to edit permalink settings, the textarea with new rules to use was not labeled. Add labels and aria-describedby pointing to the field description.

Props sabernhardt
Fixes #53142.

File:

• trunk/src/wp-admin/options-permalink.php (modified) (6 diffs)

trunk/src/wp-admin/options-permalink.php

@@ -358 +358 @@
             if ( file_exists( $home_path . 'web.config' ) ) :
                 ?>
-<p>
+<p id="iis-description-a">
                 <?php
                 printf(
@@ -372 +372 @@
 <form action="options-permalink.php" method="post">
                 <?php wp_nonce_field( 'update-permalink' ); ?>
-    <p><textarea rows="9" class="large-text readonly" name="rules" id="rules" readonly="readonly"><?php echo esc_textarea( $wp_rewrite->iis7_url_rewrite_rules() ); ?></textarea></p>
+    <p><label for="rules"><?php _e( 'Rewrite rules:' ); ?></label><br /><textarea rows="9" class="large-text readonly" name="rules" id="rules" readonly="readonly" aria-describedby="iis-description-a"><?php echo esc_textarea( $wp_rewrite->iis7_url_rewrite_rules() ); ?></textarea></p>
 </form>
 <p>
@@ -384 +384 @@
 </p>
         <?php else : ?>
-<p>
+<p id="iis-description-b">
             <?php
             printf(
@@ -397 +397 @@
 <form action="options-permalink.php" method="post">
             <?php wp_nonce_field( 'update-permalink' ); ?>
-    <p><textarea rows="18" class="large-text readonly" name="rules" id="rules" readonly="readonly"><?php echo esc_textarea( $wp_rewrite->iis7_url_rewrite_rules( true ) ); ?></textarea></p>
+    <p><label for="rules"><?php _e( 'Rewrite rules:' ); ?></label><br /><textarea rows="18" class="large-text readonly" name="rules" id="rules" readonly="readonly" aria-describedby="iis-description-b"><?php echo esc_textarea( $wp_rewrite->iis7_url_rewrite_rules( true ) ); ?></textarea></p>
 </form>
 <p>
@@ -416 +416 @@
     if ( $permalink_structure && ! $using_index_permalinks && ! $writable && $htaccess_update_required ) :
         ?>
-<p>
+<p id="htaccess-description">
         <?php
         printf(
@@ -429 +429 @@
 <form action="options-permalink.php" method="post">
         <?php wp_nonce_field( 'update-permalink' ); ?>
-    <p><textarea rows="6" class="large-text readonly" name="rules" id="rules" readonly="readonly"><?php echo esc_textarea( $wp_rewrite->mod_rewrite_rules() ); ?></textarea></p>
+    <p><label for="rules"><?php _e( 'Rewrite rules:' ); ?></label><br /><textarea rows="8" class="large-text readonly" name="rules" id="rules" readonly="readonly" aria-describedby="htaccess-description"><?php echo esc_textarea( $wp_rewrite->mod_rewrite_rules() ); ?></textarea></p>
 </form>
     <?php endif; ?>