Changeset 50842 for trunk/src/wp-includes/Requests/Cookie/Jar.php

Timestamp:

05/11/2021 07:40:41 PM (4 years ago)

Author:

desrosj

Message:

External Libraries: Update the Requests library to version 1.8.0.

While some of the changes in the 1.8.0 release have already been copied to WordPress Core in earlier releases (see [38727], [46258], [47902] and [49382]), this release contains additional improvements, including:

• A significant performance fix when using cURL.
• Improved compliance with RFC2616.

The library has also been moved under the WordPress project’s GitHub organization and can now be found at ​https://github.com/WordPress/Requests.

Props jrf, dd32, rmccue, justinahinon, netweb, schlessera, TimothyBJacobs, soulseekah, ozh, skithund, carlalexander, travisnorthcutt, desrosj.
Fixes #53101.

File:

• trunk/src/wp-includes/Requests/Cookie/Jar.php (modified) (3 diffs)

trunk/src/wp-includes/Requests/Cookie/Jar.php

@@ -69 +69 @@
      *
      * @param string $key Item key
-     * @return string Item value
+     * @return string|null Item value (null if offsetExists is false)
      */
     public function offsetGet($key) {
@@ -163 +163 @@
      * @var Requests_Response $response
      */
-    public function before_redirect_check(Requests_Response &$return) {
+    public function before_redirect_check(Requests_Response $return) {
         $url = $return->url;
         if (!$url instanceof Requests_IRI) {
@@ -169 +169 @@
         }
 
-        $cookies = Requests_Cookie::parse_from_headers($return->headers, $url);
-        $this->cookies = array_merge($this->cookies, $cookies);
+        $cookies         = Requests_Cookie::parse_from_headers($return->headers, $url);
+        $this->cookies   = array_merge($this->cookies, $cookies);
         $return->cookies = $this;
     }