Changeset 50842 for trunk/src/wp-includes/Requests/Proxy/HTTP.php

Timestamp:

05/11/2021 07:40:41 PM (4 years ago)

Author:

desrosj

Message:

External Libraries: Update the Requests library to version 1.8.0.

While some of the changes in the 1.8.0 release have already been copied to WordPress Core in earlier releases (see [38727], [46258], [47902] and [49382]), this release contains additional improvements, including:

• A significant performance fix when using cURL.
• Improved compliance with RFC2616.

The library has also been moved under the WordPress project’s GitHub organization and can now be found at ​https://github.com/WordPress/Requests.

Props jrf, dd32, rmccue, justinahinon, netweb, schlessera, TimothyBJacobs, soulseekah, ozh, skithund, carlalexander, travisnorthcutt, desrosj.
Fixes #53101.

File:

• trunk/src/wp-includes/Requests/Proxy/HTTP.php (modified) (2 diffs)

trunk/src/wp-includes/Requests/Proxy/HTTP.php

@@ -60 +60 @@
         }
         elseif (is_array($args)) {
-            if (count($args) == 1) {
+            if (count($args) === 1) {
                 list($this->proxy) = $args;
             }
-            elseif (count($args) == 3) {
+            elseif (count($args) === 3) {
                 list($this->proxy, $this->user, $this->pass) = $args;
-                $this->use_authentication = true;
+                $this->use_authentication                    = true;
             }
             else {
@@ -83 +83 @@
      * @param Requests_Hooks $hooks Hook system
      */
-    public function register(Requests_Hooks &$hooks) {
-        $hooks->register('curl.before_send', array(&$this, 'curl_before_send'));
+    public function register(Requests_Hooks $hooks) {
+        $hooks->register('curl.before_send', array($this, 'curl_before_send'));
 
-        $hooks->register('fsockopen.remote_socket', array(&$this, 'fsockopen_remote_socket'));
-        $hooks->register('fsockopen.remote_host_path', array(&$this, 'fsockopen_remote_host_path'));
+        $hooks->register('fsockopen.remote_socket', array($this, 'fsockopen_remote_socket'));
+        $hooks->register('fsockopen.remote_host_path', array($this, 'fsockopen_remote_host_path'));
         if ($this->use_authentication) {
-            $hooks->register('fsockopen.after_headers', array(&$this, 'fsockopen_header'));
+            $hooks->register('fsockopen.after_headers', array($this, 'fsockopen_header'));
         }
     }