Changeset 50842 for trunk/src/wp-includes/Requests/SSL.php

Timestamp:

05/11/2021 07:40:41 PM (4 years ago)

Author:

desrosj

Message:

External Libraries: Update the Requests library to version 1.8.0.

While some of the changes in the 1.8.0 release have already been copied to WordPress Core in earlier releases (see [38727], [46258], [47902] and [49382]), this release contains additional improvements, including:

• A significant performance fix when using cURL.
• Improved compliance with RFC2616.

The library has also been moved under the WordPress project’s GitHub organization and can now be found at ​https://github.com/WordPress/Requests.

Props jrf, dd32, rmccue, justinahinon, netweb, schlessera, TimothyBJacobs, soulseekah, ozh, skithund, carlalexander, travisnorthcutt, desrosj.
Fixes #53101.

File:

• trunk/src/wp-includes/Requests/SSL.php (modified) (3 diffs)

trunk/src/wp-includes/Requests/SSL.php

@@ -21 +21 @@
      * Unfortunately, PHP doesn't check the certificate against the alternative
      * names, leading things like 'https://www.github.com/' to be invalid.
-     * Instead
      *
      * @see https://tools.ietf.org/html/rfc2818#section-3.1 RFC2818, Section 3.1
@@ -31 +30 @@
      */
     public static function verify_certificate($host, $cert) {
-        // Calculate the valid wildcard match if the host is not an IP address
-        $parts = explode('.', $host);
-        if (ip2long($host) === false) {
-            $parts[0] = '*';
-        }
-        $wildcard = implode('.', $parts);
-
         $has_dns_alt = false;
 
@@ -140 +132 @@
         // ruleset.
         if (ip2long($host) === false) {
-            $parts = explode('.', $host);
+            $parts    = explode('.', $host);
             $parts[0] = '*';
             $wildcard = implode('.', $parts);