Changeset 50926

Timestamp:

05/18/2021 09:04:31 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertInstanceOf() instead of assertTrue() in some tests.

See #52625.

Location:

trunk/tests/phpunit/tests

Files:

• l10n/loadTextdomainJustInTime.php (modified) (1 diff)
• term/cache.php (modified) (1 diff)
• term/getTerm.php (modified) (1 diff)
• term/getTermBy.php (modified) (4 diffs)
• user/updateUserCaches.php (modified) (1 diff)

trunk/tests/phpunit/tests/l10n/loadTextdomainJustInTime.php

@@ -111 +111 @@
         remove_filter( 'locale', array( $this, 'filter_set_locale_to_german' ) );
 
-        $this->assertTrue( $translations instanceof NOOP_Translations );
+        $this->assertInstanceOf( 'NOOP_Translations', $translations );
     }
 

trunk/tests/phpunit/tests/term/cache.php

@@ -434 +434 @@
         $term = get_term_by( 'name', 'Burrito', 'post_tag' );
         $num_queries++;
-        $this->assertTrue( $term instanceof WP_Term );
+        $this->assertInstanceOf( 'WP_Term', $term );
         $this->assertSame( $term_id, $term->term_id );
         $this->assertSame( $num_queries, $wpdb->num_queries );

trunk/tests/phpunit/tests/term/getTerm.php

@@ -136 +136 @@
         $found = get_term( $term_data );
 
-        $this->assertTrue( $found instanceof WP_Term );
+        $this->assertInstanceOf( 'WP_Term', $found );
         $this->assertInternalType( 'int', $found->term_id );
         $this->assertInternalType( 'int', $found->term_taxonomy_id );

trunk/tests/phpunit/tests/term/getTermBy.php

@@ -126 +126 @@
         $num_queries++;
 
-        $this->assertTrue( $found instanceof WP_Term );
+        $this->assertInstanceOf( 'WP_Term', $found );
         $this->assertSame( $t, $found->term_id );
         $this->assertSame( $num_queries, $wpdb->num_queries );
@@ -152 +152 @@
         $found = get_term_by( 'name', $term_name_slashed, 'wptests_tax' );
 
-        $this->assertTrue( $found instanceof WP_Term );
+        $this->assertInstanceOf( 'WP_Term', $found );
         $this->assertSame( $t, $found->term_id );
         $this->assertSame( $term_name, $found->name );
@@ -172 +172 @@
         $found1 = get_term_by( 'slug', 'foo foo', 'wptests_tax' );
 
-        $this->assertTrue( $found1 instanceof WP_Term );
+        $this->assertInstanceOf( 'WP_Term', $found1 );
         $this->assertSame( $t1, $found1->term_id );
 
@@ -185 +185 @@
         $found2 = get_term_by( 'slug', '仪表盘', 'wptests_tax' );
 
-        $this->assertTrue( $found2 instanceof WP_Term );
+        $this->assertInstanceOf( 'WP_Term', $found2 );
         $this->assertSame( $t2, $found2->term_id );
     }

trunk/tests/phpunit/tests/user/updateUserCaches.php

@@ -65 +65 @@
 
         $cached = wp_cache_get( $u, 'users' );
-        $this->assertFalse( $cached instanceof WP_User );
+        $this->assertNotInstanceOf( 'WP_User', $cached );
         $this->assertEquals( $raw_userdata, $cached );
     }