Changeset 50935 for trunk/tests/phpunit/tests/post/objects.php

Timestamp:

05/19/2021 10:10:58 PM (5 years ago)

Author:

SergeyBiryukov

Message:

General: Ensure consistent type for integer properties of WP_Post, WP_Term, and WP_User.

Previously, these properties could be unexpectedly converted to strings in some contexts.

This applies to the following functions:

• sanitize_post_field()
• sanitize_term_field()
• sanitize_user_field()

and the following properties:

• WP_Post::ID
• WP_Post::post_parent
• WP_Post::menu_order
• WP_Term::term_id
• WP_Term::term_taxonomy_id
• WP_Term::parent
• WP_Term::count
• WP_Term::term_group
• WP_User::ID

Props grantmkin, SergeyBiryukov.
Fixes #53235. See #52995.

File:

• trunk/tests/phpunit/tests/post/objects.php (modified) (1 diff)

trunk/tests/phpunit/tests/post/objects.php

@@ -185 +185 @@
     }
 
+    /**
+     * @ticket 53235
+     */
+    public function test_numeric_properties_should_be_cast_to_ints() {
+        $post_id  = self::factory()->post->create();
+        $contexts = array( 'raw', 'edit', 'db', 'display', 'attribute', 'js' );
+
+        foreach ( $contexts as $context ) {
+            $post = get_post( $post_id, OBJECT, $context );
+
+            $this->assertInternalType( 'int', $post->ID );
+            $this->assertInternalType( 'int', $post->post_parent );
+            $this->assertInternalType( 'int', $post->menu_order );
+        }
+    }
+
     function test_get_post_identity() {
         $post = get_post( self::factory()->post->create() );