Changeset 50935 for trunk/tests/phpunit/tests/term/getTerm.php

Timestamp:

05/19/2021 10:10:58 PM (5 years ago)

Author:

SergeyBiryukov

Message:

General: Ensure consistent type for integer properties of WP_Post, WP_Term, and WP_User.

Previously, these properties could be unexpectedly converted to strings in some contexts.

This applies to the following functions:

• sanitize_post_field()
• sanitize_term_field()
• sanitize_user_field()

and the following properties:

• WP_Post::ID
• WP_Post::post_parent
• WP_Post::menu_order
• WP_Term::term_id
• WP_Term::term_taxonomy_id
• WP_Term::parent
• WP_Term::count
• WP_Term::term_group
• WP_User::ID

Props grantmkin, SergeyBiryukov.
Fixes #53235. See #52995.

File:

• trunk/tests/phpunit/tests/term/getTerm.php (modified) (2 diffs)

trunk/tests/phpunit/tests/term/getTerm.php

@@ -125 +125 @@
     /**
      * @ticket 14162
+     * @ticket 53235
      */
     public function test_numeric_properties_should_be_cast_to_ints() {
@@ -134 +135 @@
         $term_data = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $wpdb->terms t JOIN $wpdb->term_taxonomy tt ON ( t.term_id = tt.term_id ) WHERE t.term_id = %d", $t ) );
 
-        $found = get_term( $term_data );
-
-        $this->assertInstanceOf( 'WP_Term', $found );
-        $this->assertInternalType( 'int', $found->term_id );
-        $this->assertInternalType( 'int', $found->term_taxonomy_id );
-        $this->assertInternalType( 'int', $found->parent );
-        $this->assertInternalType( 'int', $found->count );
-        $this->assertInternalType( 'int', $found->term_group );
+        $contexts = array( 'raw', 'edit', 'db', 'display', 'rss', 'attribute', 'js' );
+
+        foreach ( $contexts as $context ) {
+            $found = get_term( $term_data, '', OBJECT, $context );
+
+            $this->assertInstanceOf( 'WP_Term', $found );
+            $this->assertInternalType( 'int', $found->term_id );
+            $this->assertInternalType( 'int', $found->term_taxonomy_id );
+            $this->assertInternalType( 'int', $found->parent );
+            $this->assertInternalType( 'int', $found->count );
+            $this->assertInternalType( 'int', $found->term_group );
+        }
     }