Changeset 50936 for trunk/tests/phpunit/tests/bookmark/getBookmark.php

Timestamp:

05/20/2021 12:03:04 AM (4 years ago)

Author:

SergeyBiryukov

Message:

General: Ensure consistent type for integer properties of a bookmark object.

Previously, these properties could be unexpectedly converted to strings in some contexts.

This applies to the following function:

• sanitize_bookmark_field()

and the following properties:

• $bookmark::link_id
• $bookmark::link_rating

Follow-up to [50935].

See #53235.

File:

• trunk/tests/phpunit/tests/bookmark/getBookmark.php (modified) (1 diff)

trunk/tests/phpunit/tests/bookmark/getBookmark.php

@@ -342 +342 @@
 
     /**
+     * @ticket 53235
+     */
+    public function test_numeric_properties_should_be_cast_to_ints() {
+        $contexts = array( 'raw', 'edit', 'db', 'display', 'attribute', 'js' );
+
+        foreach ( $contexts as $context ) {
+            $bookmark = get_bookmark( self::$bookmark->link_id, OBJECT, $context );
+
+            $this->assertInternalType( 'int', $bookmark->link_id );
+            $this->assertInternalType( 'int', $bookmark->link_rating );
+        }
+    }
+
+    /**
      * Initialize the get_bookmark's function arguments to match the order of the function's signature and
      * reduce code in the tests.