Changeset 50939

Timestamp:

05/20/2021 11:08:15 AM (3 years ago)

Author:

Clorith

Message:

Site Health: Skip REST tests during scheduled events.

This change fixes a false positive that would appear during scheduled events, by only running the REST test when a user visits the Site Health page, meaning an active session is available.

The test checking if the REST API is available, includes a parameter for context=edit to make sure the block editor can function properly. This means a user session with editor capabilities is required for the test to pass, which is not the case during a scheduled event.

Props szaqal21, TimothyBlynJacobs, hermpheus.
Fixes #52112.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -2362 +2362 @@
         if ( function_exists( 'rest_url' ) ) {
             $tests['direct']['rest_availability'] = array(
-                'label' => __( 'REST API availability' ),
-                'test'  => 'rest_availability',
+                'label'     => __( 'REST API availability' ),
+                'test'      => 'rest_availability',
+                'skip_cron' => true,
             );
         }
@@ -2730 +2731 @@
 
         foreach ( $tests['direct'] as $test ) {
+            if ( ! empty( $test['skip_cron'] ) ) {
+                continue;
+            }
 
             if ( is_string( $test['test'] ) ) {