Changeset 50953 for trunk/src/wp-includes/class-wp-widget.php

Timestamp:

05/23/2021 08:50:44 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Widgets: Make sure WP_Widget constructor creates a correct id_base value for a namespaced widget class.

The id_base value is used for the widget's id and class attributes and also for the option name which stores the widget settings (unless the widget specifies a custom option_name value).

With this change, any backslashes in the id_base for a namespaced widget class are converted to hyphens, making it easier to style the output or target the widget with JavaScript.

This also avoids a preg_match(): Compilation failed PHP warning from next_widget_id_number() on the Widgets screen, previously caused by unescaped backslashes.

Props Mte90, hermpheus, rogerlos, welcher, SergeyBiryukov.
Fixes #44098.

File:

• trunk/src/wp-includes/class-wp-widget.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-widget.php

@@ -161 +161 @@
      */
     public function __construct( $id_base, $name, $widget_options = array(), $control_options = array() ) {
-        $this->id_base         = empty( $id_base ) ? preg_replace( '/(wp_)?widget_/', '', strtolower( get_class( $this ) ) ) : strtolower( $id_base );
+        if ( ! empty( $id_base ) ) {
+            $id_base = strtolower( $id_base );
+        } else {
+            $id_base = preg_replace( '/(wp_)?widget_/', '', strtolower( get_class( $this ) ) );
+            $id_base = str_replace( '\\', '-', $id_base );
+        }
+
+        $this->id_base         = $id_base;
         $this->name            = $name;
         $this->option_name     = 'widget_' . $this->id_base;