Changeset 50961 for trunk/src/wp-includes/class-wp-widget.php

Timestamp:

05/24/2021 09:50:30 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Widgets: Make sure WP_Widget constructor creates a correct classname value for a namespaced widget class.

This reverts the changes to id_base from [50953] due to backward compatibility concerns, and instead focuses on the id and class attributes specifically.

With this change, any backslashes in the id or class attributes for a namespaced widget class are converted to underscores, making it easier to style the output or target the widget with JavaScript.

Follow-up to [50953].

Fixes #44098.

File:

• trunk/src/wp-includes/class-wp-widget.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-widget.php

@@ -165 +165 @@
         } else {
             $id_base = preg_replace( '/(wp_)?widget_/', '', strtolower( get_class( $this ) ) );
-            $id_base = str_replace( '\\', '-', $id_base );
         }
 
@@ -174 +173 @@
             $widget_options,
             array(
-                'classname'                   => $this->option_name,
+                'classname'                   => str_replace( '\\', '_', $this->option_name ),
                 'customize_selective_refresh' => false,
             )