Changeset 50961 for trunk/src/wp-includes/widgets.php

Timestamp:

05/24/2021 09:50:30 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Widgets: Make sure WP_Widget constructor creates a correct classname value for a namespaced widget class.

This reverts the changes to id_base from [50953] due to backward compatibility concerns, and instead focuses on the id and class attributes specifically.

With this change, any backslashes in the id or class attributes for a namespaced widget class are converted to underscores, making it easier to style the output or target the widget with JavaScript.

Follow-up to [50953].

Fixes #44098.

File:

• trunk/src/wp-includes/widgets.php (modified) (1 diff)

trunk/src/wp-includes/widgets.php

@@ -754 +754 @@
             }
         }
-        $classname_                 = ltrim( $classname_, '_' );
-        $params[0]['before_widget'] = sprintf( $params[0]['before_widget'], $id, $classname_ );
+        $classname_ = ltrim( $classname_, '_' );
+
+        $params[0]['before_widget'] = sprintf(
+            $params[0]['before_widget'],
+            str_replace( '\\', '_', $id ),
+            $classname_
+        );
 
         /**