Changeset 50979

Timestamp:

05/24/2021 07:23:05 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Make sure the submit_button() function is available in request_filesystem_credentials().

This avoids a fatal error when the function is called via REST API from WP_Site_Health_Auto_Updates::test_check_wp_filesystem_method().

Props lakrisgubben, mukesh27, Clorith, SergeyBiryukov.
Fixes #53206.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-site-health-auto-updates.php (modified) (2 diffs)
• file.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php

@@ -274 +274 @@
      */
     function test_check_wp_filesystem_method() {
-        // Make sure the `request_filesystem_credentials` function is available during our REST call.
+        // Make sure the `request_filesystem_credentials()` function is available during our REST API call.
         if ( ! function_exists( 'request_filesystem_credentials' ) ) {
             require_once ABSPATH . '/wp-admin/includes/file.php';
@@ -325 +325 @@
         }
 
-        // Make sure the `get_core_checksums` function is available during our REST call.
+        // Make sure the `get_core_checksums()` function is available during our REST API call.
         if ( ! function_exists( 'get_core_checksums' ) ) {
             require_once ABSPATH . '/wp-admin/includes/update.php';

trunk/src/wp-admin/includes/file.php

@@ -2370 +2370 @@
         }
     }
+
+    // Make sure the `submit_button()` function is available during the REST API call
+    // from WP_Site_Health_Auto_Updates::test_check_wp_filesystem_method().
+    if ( ! function_exists( 'submit_button' ) ) {
+        require_once ABSPATH . '/wp-admin/includes/template.php';
+    }
     ?>
     <p class="request-filesystem-credentials-action-buttons">