Changeset 50981 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

05/24/2021 07:58:13 PM (3 years ago)

Author:

desrosj

Message:

General: Avoid unnecessary calls to update_user_option().

The update_user_option() function is a way to update a user meta value after adding a blog’s prefix to the beginning of the meta key. But when the fourth parameter is true, the behavior is exactly the same as calling update_user_meta() directly.

This replaces all instances of update_user_option() when the fourth parameter is true in Core with a direct call to update_user_meta() to prevent an unnecessary call to update_user_option().

Props johnjamesjacoby, zkancs, obenland, desrosj.
Fixes #43339.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (5 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -375 +375 @@
          */
         if ( $ip_changed || $search ) {
-            update_user_option( $user_id, 'community-events-location', $events['location'], true );
+            update_user_meta( $user_id, 'community-events-location', $events['location'] );
         }
 
@@ -1734 +1734 @@
 
     if ( is_array( $closed ) ) {
-        update_user_option( $user->ID, "closedpostboxes_$page", $closed, true );
+        update_user_meta( $user->ID, "closedpostboxes_$page", $closed );
     }
 
@@ -1740 +1740 @@
         // Postboxes that are always shown.
         $hidden = array_diff( $hidden, array( 'submitdiv', 'linksubmitdiv', 'manage-menu', 'create-menu' ) );
-        update_user_option( $user->ID, "metaboxhidden_$page", $hidden, true );
+        update_user_meta( $user->ID, "metaboxhidden_$page", $hidden );
     }
 
@@ -1765 +1765 @@
 
     $hidden = ! empty( $_POST['hidden'] ) ? explode( ',', $_POST['hidden'] ) : array();
-    update_user_option( $user->ID, "manage{$page}columnshidden", $hidden, true );
+    update_user_meta( $user->ID, "manage{$page}columnshidden", $hidden );
 
     wp_die( 1 );
@@ -1920 +1920 @@
 
     if ( $order ) {
-        update_user_option( $user->ID, "meta-box-order_$page", $order, true );
+        update_user_meta( $user->ID, "meta-box-order_$page", $order );
     }
 
     if ( $page_columns ) {
-        update_user_option( $user->ID, "screen_layout_$page", $page_columns, true );
+        update_user_meta( $user->ID, "screen_layout_$page", $page_columns );
     }