Changeset 50981 for trunk/src/wp-admin/includes/nav-menu.php

Timestamp:

05/24/2021 07:58:13 PM (4 years ago)

Author:

desrosj

Message:

General: Avoid unnecessary calls to update_user_option().

The update_user_option() function is a way to update a user meta value after adding a blog’s prefix to the beginning of the meta key. But when the fourth parameter is true, the behavior is exactly the same as calling update_user_meta() directly.

This replaces all instances of update_user_option() when the fourth parameter is true in Core with a direct call to update_user_meta() to prevent an unnecessary call to update_user_option().

Props johnjamesjacoby, zkancs, obenland, desrosj.
Fixes #43339.

File:

• trunk/src/wp-admin/includes/nav-menu.php (modified) (3 diffs)

trunk/src/wp-admin/includes/nav-menu.php

@@ -155 +155 @@
     if ( false === get_user_option( 'managenav-menuscolumnshidden' ) ) {
         $user = wp_get_current_user();
-        update_user_option(
+        update_user_meta(
             $user->ID,
             'managenav-menuscolumnshidden',
@@ -164 +164 @@
                 3 => 'description',
                 4 => 'title-attribute',
-            ),
-            true
+            )
         );
     }
@@ -200 +199 @@
 
     $user = wp_get_current_user();
-    update_user_option( $user->ID, 'metaboxhidden_nav-menus', $hidden_meta_boxes, true );
+    update_user_meta( $user->ID, 'metaboxhidden_nav-menus', $hidden_meta_boxes );
 }