Changeset 50981 for trunk/src/wp-admin/includes/upgrade.php

Timestamp:

05/24/2021 07:58:13 PM (3 years ago)

Author:

desrosj

Message:

General: Avoid unnecessary calls to update_user_option().

The update_user_option() function is a way to update a user meta value after adding a blog’s prefix to the beginning of the meta key. But when the fourth parameter is true, the behavior is exactly the same as calling update_user_meta() directly.

This replaces all instances of update_user_option() when the fourth parameter is true in Core with a direct call to update_user_meta() to prevent an unnecessary call to update_user_option().

Props johnjamesjacoby, zkancs, obenland, desrosj.
Fixes #43339.

File:

• trunk/src/wp-admin/includes/upgrade.php (modified) (1 diff)

trunk/src/wp-admin/includes/upgrade.php

@@ -89 +89 @@
             $message       = __( '<strong><em>Note that password</em></strong> carefully! It is a <em>random</em> password that was generated just for you.' );
             $user_id       = wp_create_user( $user_name, $user_password, $user_email );
-            update_user_option( $user_id, 'default_password_nag', true, true );
+            update_user_meta( $user_id, 'default_password_nag', true );
             $email_password = true;
             $user_created   = true;