Changeset 50981 for trunk/src/wp-admin/includes/user.php

Timestamp:

05/24/2021 07:58:13 PM (4 years ago)

Author:

desrosj

Message:

General: Avoid unnecessary calls to update_user_option().

The update_user_option() function is a way to update a user meta value after adding a blog’s prefix to the beginning of the meta key. But when the fourth parameter is true, the behavior is exactly the same as calling update_user_meta() directly.

This replaces all instances of update_user_option() when the fourth parameter is true in Core with a direct call to update_user_meta() to prevent an unnecessary call to update_user_option().

Props johnjamesjacoby, zkancs, obenland, desrosj.
Fixes #43339.

File:

• trunk/src/wp-admin/includes/user.php (modified) (2 diffs)

trunk/src/wp-admin/includes/user.php

@@ -483 +483 @@
     ) {
         delete_user_setting( 'default_password_nag' );
-        update_user_option( $user_ID, 'default_password_nag', false, true );
+        update_user_meta( $user_ID, 'default_password_nag', false );
     }
 }
@@ -504 +504 @@
     if ( $new_data->user_pass != $old_data->user_pass ) {
         delete_user_setting( 'default_password_nag' );
-        update_user_option( $user_ID, 'default_password_nag', false, true );
+        update_user_meta( $user_ID, 'default_password_nag', false );
     }
 }