Changeset 51079 for trunk/tests/phpunit/tests/block-template-utils.php

Timestamp:

06/07/2021 11:16:29 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in some newly introduced tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [50380], [50959], [50960], [50973], [50993], [51003], [51051], [51054].

See #52482.

File:

• trunk/tests/phpunit/tests/block-template-utils.php (modified) (3 diffs)

trunk/tests/phpunit/tests/block-template-utils.php

@@ -41 +41 @@
 
         $this->assertNotWPError( $template );
-        $this->assertEquals( get_stylesheet() . '//my_template', $template->id );
-        $this->assertEquals( get_stylesheet(), $template->theme );
-        $this->assertEquals( 'my_template', $template->slug );
-        $this->assertEquals( 'publish', $template->status );
-        $this->assertEquals( 'custom', $template->source );
-        $this->assertEquals( 'My Template', $template->title );
-        $this->assertEquals( 'Description of my template', $template->description );
-        $this->assertEquals( 'wp_template', $template->type );
+        $this->assertSame( get_stylesheet() . '//my_template', $template->id );
+        $this->assertSame( get_stylesheet(), $template->theme );
+        $this->assertSame( 'my_template', $template->slug );
+        $this->assertSame( 'publish', $template->status );
+        $this->assertSame( 'custom', $template->source );
+        $this->assertSame( 'My Template', $template->title );
+        $this->assertSame( 'Description of my template', $template->description );
+        $this->assertSame( 'wp_template', $template->type );
     }
 
@@ -57 +57 @@
         $id       = get_stylesheet() . '//' . 'my_template';
         $template = get_block_template( $id, 'wp_template' );
-        $this->assertEquals( $id, $template->id );
-        $this->assertEquals( get_stylesheet(), $template->theme );
-        $this->assertEquals( 'my_template', $template->slug );
-        $this->assertEquals( 'publish', $template->status );
-        $this->assertEquals( 'custom', $template->source );
-        $this->assertEquals( 'wp_template', $template->type );
+        $this->assertSame( $id, $template->id );
+        $this->assertSame( get_stylesheet(), $template->theme );
+        $this->assertSame( 'my_template', $template->slug );
+        $this->assertSame( 'publish', $template->status );
+        $this->assertSame( 'custom', $template->source );
+        $this->assertSame( 'wp_template', $template->type );
     }
 
@@ -88 +88 @@
         $templates    = get_block_templates( array( 'slug__in' => array( 'my_template' ) ), 'wp_template' );
         $template_ids = get_template_ids( $templates );
-        $this->assertEquals( array( get_stylesheet() . '//' . 'my_template' ), $template_ids );
+        $this->assertSame( array( get_stylesheet() . '//' . 'my_template' ), $template_ids );
 
         // Filter by CPT ID.
         $templates    = get_block_templates( array( 'wp_id' => self::$post->ID ), 'wp_template' );
         $template_ids = get_template_ids( $templates );
-        $this->assertEquals( array( get_stylesheet() . '//' . 'my_template' ), $template_ids );
+        $this->assertSame( array( get_stylesheet() . '//' . 'my_template' ), $template_ids );
     }
 }