Changeset 51079 for trunk/tests/phpunit/tests/bookmark/getBookmark.php

Timestamp:

06/07/2021 11:16:29 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in some newly introduced tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [50380], [50959], [50960], [50973], [50993], [51003], [51051], [51054].

See #52482.

File:

• trunk/tests/phpunit/tests/bookmark/getBookmark.php (modified) (2 diffs)

trunk/tests/phpunit/tests/bookmark/getBookmark.php

@@ -229 +229 @@
 
         /*
-         * For non-array output type, use assetEquals. Why? The object pulled from cache will have the same
-         * property values but will be a different object than the expected object.
+         * For non-array output type, use assertEquals(). Why? The object pulled from the cache
+         * will have the same property values but will be a different object than the expected object.
          */
         if ( is_object( $expected ) ) {
@@ -287 +287 @@
 
         /*
-         * For non-array output type, use assetEquals. Why? The object pulled from the database will have the same
-         * property values but will be a different object than the expected object.
+         * For non-array output type, use assertEquals(). Why? The object pulled from the database
+         * will have the same property values but will be a different object than the expected object.
          */
         if ( is_object( $expected ) ) {