WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
06/07/2021 11:16:29 AM (5 years ago)
Author:
SergeyBiryukov
Message:

Tests: Use assertSame() in some newly introduced tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [50380], [50959], [50960], [50973], [50993], [51003], [51051], [51054].

See #52482.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/rest-api/rest-widget-types-controller.php

    r51049 r51079  
    308308        $response = rest_get_server()->dispatch( $request );
    309309        $data     = $response->get_data();
    310         $this->assertEquals(
     310        $this->assertSame(
    311311            "<p>\n" .
    312312            "\t\t\t<label for=\"widget-search--1-title\">Title:</label>\n" .
    … …  
    344344        $response = rest_get_server()->dispatch( $request );
    345345        $data     = $response->get_data();
    346         $this->assertEquals(
     346        $this->assertSame(
    347347            "<p>\n" .
    348348            "\t\t\t<label for=\"widget-search-8-title\">Title:</label>\n" .
    … …  
    386386        $response = rest_get_server()->dispatch( $request );
    387387        $data     = $response->get_data();
    388         $this->assertEquals(
     388        $this->assertSame(
    389389            "<p>\n" .
    390390            "\t\t\t<label for=\"widget-search--1-title\">Title:</label>\n" .
    … …  
    422422        $response = rest_get_server()->dispatch( $request );
    423423        $data     = $response->get_data();
    424         $this->assertEquals(
     424        $this->assertSame(
    425425            "<p>\n" .
    426426            "\t\t\t<label for=\"widget-search--1-title\">Title:</label>\n" .
    … …  
    466466        $response = rest_get_server()->dispatch( $request );
    467467        $data     = $response->get_data();
    468         $this->assertEquals(
     468        $this->assertSame(
    469469            "<p>\n" .
    470470            "\t\t\t<label for=\"widget-search--1-title\">Title:</label>\n" .
Note: See TracChangeset for help on using the changeset viewer.