Changeset 51086

Timestamp:

06/07/2021 11:48:18 PM (4 years ago)

Author:

joedolson

Message:

Application Passwords: Allow enter key to submit profile form.

Fix the enter key in profile form fields moving focus to the application password input instead of submitting the profile update for. Replace the submit button type used for application passwords with button type="button" and ensure that the enter key's native behavior isn't overwritten.

props audrasjb, alexstine, promz, sabernhardt.
Fixes #52849.

Location:

trunk/src

Files:

• js/_enqueues/admin/application-passwords.js (modified) (1 diff)
• wp-admin/includes/class-wp-application-passwords-list-table.php (modified) (3 diffs)
• wp-admin/user-edit.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/application-passwords.js

@@ -149 +149 @@
             } );
         } );
+    } );
+
+    $newAppPassField.on( 'keypress', function ( e ) {
+        if ( 13 === e.which ) {
+            e.preventDefault();
+            $newAppPassButton.trigger( 'click' );
+        }
     } );
 

trunk/src/wp-admin/includes/class-wp-application-passwords-list-table.php

@@ -111 +111 @@
      */
     public function column_revoke( $item ) {
-        submit_button(
-            __( 'Revoke' ),
-            'delete',
-            'revoke-application-password-' . $item['uuid'],
-            false,
-            array(
-                /* translators: %s: the application password's given name. */
-                'aria-label' => sprintf( __( 'Revoke "%s"' ), $item['name'] ),
-            )
+        $name = 'revoke-application-password-' . $item['uuid'];
+        printf(
+            '<button type="button" name="%1$s" id="%1$s" class="button delete" aria-label="%2$s">%3$s</button>',
+            esc_attr( $name ),
+            /* translators: %s: the application password's given name. */
+            esc_attr( sprintf( __( 'Revoke "%s"' ), $item['name'] ) ),
+            __( 'Revoke' )
         );
     }
@@ -157 +155 @@
             <?php if ( 'bottom' === $which ) : ?>
                 <div class="alignright">
-                    <?php submit_button( __( 'Revoke all application passwords' ), 'delete', 'revoke-all-application-passwords', false ); ?>
+                    <button type="button" name="revoke-all-application-passwords" id="revoke-all-application-passwords" class="button delete"><?php _e( 'Revoke all application passwords' ); ?></button>
                 </div>
             <?php endif; ?>
@@ -236 +234 @@
                 case 'revoke':
                     printf(
-                        '<input type="submit" class="button delete" value="%1$s" aria-label="%2$s">',
-                        esc_attr__( 'Revoke' ),
+                        '<button type="button" class="button delete" aria-label="%1$s">%2$s</button>',
                         /* translators: %s: the application password's given name. */
-                        esc_attr( sprintf( __( 'Revoke "%s"' ), '{{ data.name }}' ) )
+                        esc_attr( sprintf( __( 'Revoke "%s"' ), '{{ data.name }}' ) ),
+                        esc_html__( 'Revoke' )
                     );
                     break;

trunk/src/wp-admin/user-edit.php

@@ -781 +781 @@
                 ?>
 
-                <?php submit_button( __( 'Add New Application Password' ), 'secondary', 'do_new_application_password' ); ?>
+                <button type="button" name="do_new_application_password" id="do_new_application_password" class="button button-secondary"><?php _e( 'Add New Application Password' ); ?></button>
             </div>
         <?php } else { ?>