Changeset 51121

Timestamp:

06/08/2021 10:59:19 PM (4 years ago)

Author:

antpb

Message:

Feeds: Avoid notices in get_post_comments_feed_link().

When an feed request is made to a non-existent page, surpress the notice.

Props dd32, SergeyBiryukov, mukesh27, hellofromTonya.
Fixes #52814.

Location:

trunk

Files:

• src/wp-includes/link-template.php (modified) (2 diffs)
• tests/phpunit/tests/link/getPostCommentsFeedLink.php (modified) (1 diff)

trunk/src/wp-includes/link-template.php

@@ -736 +736 @@
  * @param string $feed    Optional. Feed type. Possible values include 'rss2', 'atom'.
  *                        Default is the value of get_default_feed().
- * @return string The permalink for the comments feed for the given post.
+ * @return string The permalink for the comments feed for the given post on success, empty string on failure.
  */
 function get_post_comments_feed_link( $post_id = 0, $feed = '' ) {
@@ -749 +749 @@
     }
 
-    $post       = get_post( $post_id );
+    $post = get_post( $post_id );
+
+    // Bail out if the post does not exist.
+    if ( ! $post instanceof WP_Post ) {
+        return '';
+    }
+
     $unattached = 'attachment' === $post->post_type && 0 === (int) $post->post_parent;
 

trunk/tests/phpunit/tests/link/getPostCommentsFeedLink.php

@@ -139 +139 @@
         $this->assertSame( $expected, $link );
     }
+
+    /**
+     * @ticket 52814
+     */
+    public function test_nonexistent_page() {
+        $this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
+
+        // Use the largest integer to ensure the post does not exist.
+        $post_id = PHP_INT_MAX;
+        $link    = get_post_comments_feed_link( $post_id );
+
+        $this->assertEmpty( $link );
+    }
 }