Changeset 51124

Timestamp:

06/08/2021 11:23:12 PM (2 years ago)

Author:

whyisjake

Message:

Revisions: Check and return errors for insertions to revisions.

Fixes #30009.

Props rmccue, adamsilverstein, coreymckrill, whyisjake.

Location:

trunk

Files:

• src/wp-includes/revision.php (modified) (1 diff)
• tests/phpunit/tests/post/revisions.php (modified) (1 diff)

trunk/src/wp-includes/revision.php

@@ -332 +332 @@
     $post = wp_slash( $post ); // Since data is from DB.
 
-    $revision_id = wp_insert_post( $post );
+    $revision_id = wp_insert_post( $post, true );
     if ( is_wp_error( $revision_id ) ) {
         return $revision_id;

trunk/tests/phpunit/tests/post/revisions.php

@@ -636 +636 @@
         $this->assertSame( $expected, wp_revisions_to_keep( $post ) );
     }
+
+
+    /*
+     * Verify that trying to create a revision with an invalid ID returns a WP_Error.
+     *
+     *
+     * @ticket 30009
+     */
+    public function test_wp_save_post_revision_error() {
+        $post     = self::factory()->post->create_and_get(
+            array(
+                'ID' => PHP_INT_MAX,
+            )
+        );
+        $revision = _wp_put_post_revision( $post );
+        $this->assertTrue( is_wp_error( $revision ) );
+    }
 }