Changeset 51144

Timestamp:

06/14/2021 08:38:38 PM (5 years ago)

Author:

jorbin

Message:

Block Editor: Prevent duplicate queries

When passing args to WP_Query::__construct method (in this case, but creating a new WP_Query, this one internally executes the WP_Query::get_posts method and stores the result in the WP_Query::posts property. When calling the WP_Query::get_posts again, the same SQL query gets executed, and the result is again stored in the WP_Query::posts property.

This was introduced in [51003].

Props david.binda, jorbin.
Fixes #53280. See #53176.

Location:

trunk/src/wp-includes

Files:

• block-template-utils.php (modified) (2 diffs)
• theme-templates.php (modified) (2 diffs)

trunk/src/wp-includes/block-template-utils.php

@@ -89 +89 @@
         $template_query = new WP_Query( $wp_query_args );
         $query_result   = array();
-        foreach ( $template_query->get_posts() as $post ) {
+        foreach ( $template_query->posts as $post ) {
                 $template = _build_template_result_from_post( $post );
 
@@ -131 +131 @@
         );
         $template_query       = new WP_Query( $wp_query_args );
-        $posts                = $template_query->get_posts();
+        $posts                = $template_query->posts;
 
         if ( count( $posts ) > 0 ) {

trunk/src/wp-includes/theme-templates.php

@@ -50 +50 @@
         );
         $check_query      = new WP_Query( $check_query_args );
-        $posts            = $check_query->get_posts();
+        $posts            = $check_query->posts;
 
         if ( count( $posts ) > 0 ) {
@@ -60 +60 @@
                         $query                       = new WP_Query( $query_args );
                         $suffix++;
-                } while ( count( $query->get_posts() ) > 0 );
+                } while ( count( $query->posts ) > 0 );
                 $override_slug = $alt_post_name;
         }