Changeset 51174

Timestamp:

06/17/2021 11:28:55 AM (5 years ago)

Author:

SergeyBiryukov

Message:

REST API: Decode HTML entities in widget names and descriptions in widget types controller.

Follow-up to [50995].

Props ramonopoly, noisysocks, spacedmonkey, justinahinon, audrasjb, SergeyBiryukov.
Fixes #53407.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-widget-types-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-widget-types-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-widget-types-controller.php

@@ -211 +211 @@
                         $widget_object = $wp_widget_factory->get_widget_object( $parsed_id['id_base'] );
 
-                        $widget['id']       = $parsed_id['id_base'];
-                        $widget['is_multi'] = (bool) $widget_object;
+                        $widget['id']          = $parsed_id['id_base'];
+                        $widget['is_multi']    = (bool) $widget_object;
+
+                        if ( isset( $widget['name'] ) ) {
+                                $widget['name'] = html_entity_decode( $widget['name'] );
+                        }
+
+                        if ( isset( $widget['description'] ) ) {
+                                $widget['description'] = html_entity_decode( $widget['description'] );
+                        }
 
                         unset( $widget['callback'] );

trunk/tests/phpunit/tests/rest-api/rest-widget-types-controller.php

@@ -200 +200 @@
 
         /**
+         * @ticket 53407
+         */
+        public function test_get_widgets_decodes_html_entities() {
+                wp_set_current_user( self::$admin_id );
+                $widget_id = 'archives';
+                wp_register_sidebar_widget(
+                        $widget_id,
+                        'Legacy ‑ Archive ‑ Widget',
+                        function() {},
+                        array(
+                                'description' => 'A great & interesting archive of your site’s posts!',
+                        )
+                );
+                $request  = new WP_REST_Request( 'GET', '/wp/v2/widget-types/archives' );
+                $response = rest_get_server()->dispatch( $request );
+                $data     = $response->get_data();
+                $this->assertSame( 'Legacy ‑ Archive ‑ Widget', $data['name'] );
+                $this->assertSame( 'A great & interesting archive of your site’s posts!', $data['description'] );
+        }
+
+        /**
          * @ticket 41683
          */
@@ -493 +514 @@
         }
 
-
         /**
          * The test_create_item() method does not exist for widget types.