Changeset 51202

Timestamp:

06/22/2021 04:54:50 PM (3 years ago)

Author:

desrosj

Message:

Widgets: Stop loading wp-editor and the Block Directory assets on the widgets screen.

When using the text widget, a wp.editor.initialize is not a function notice is encountered. This happens when wp-editor is loaded as a dependency, which assigns wp.oldEditor = wp.editor and then redefines wp.editor.

wp-editor is only used for the Classic block, which is not supported in the new widgets editor. [51198-51199] updated @wordpress/block-library to remove wp-editor as a dependency, but it’s still listed as a dependency of the wp-block-directory script handle.

Since the Block directory is not supported within the widgets editor, the related assets can safely be blocked from enqueueing.

Props noisysocks, gziolo, Mamaduka, mkaz.
Fixes #53437. See #53397.

File:

• trunk/src/wp-admin/widgets-form-blocks.php (modified) (2 diffs)

trunk/src/wp-admin/widgets-form-blocks.php

@@ -29 +29 @@
     $block_editor_context
 );
+
+// The widgets editor does not support the Block Directory, so don't load any of
+// its assets. This also prevents 'wp-editor' from being enqueued which we
+// cannot load in the widgets screen because many widget scripts rely on `wp.editor`.
+remove_action( 'enqueue_block_editor_assets', 'wp_enqueue_editor_block_directory_assets' );
 
 wp_add_inline_script(
@@ -68 +73 @@
 ?>
 
-<div id="widgets-editor" class="blocks-widgets-container"></div> 
+<div id="widgets-editor" class="blocks-widgets-container"></div>
 
 <?php