Changeset 51252

Timestamp:

06/28/2021 11:06:31 PM (3 years ago)

Author:

Clorith

Message:

Site Health: Improve readability of site titles.

This splits up the site title for the Site Health tabs to make it more obvious what page a user is viewing, and which tab under that page. It also removes a possible source of warnings if a user tries accessing a tab that does not exist.

The introduction of this check for existing tabs also improves the accuracy of the active-tab indicator, ensuring the indicator shows up for the default tab, when no other tab has been selected.

Follow-up to [50764].

Props audrasjb, swissspidy.
Fixes #53535.

File:

• trunk/src/wp-admin/site-health.php (modified) (2 diffs)

trunk/src/wp-admin/site-health.php

@@ -37 +37 @@
 );
 
+$current_tab = ( isset( $_GET['tab'] ) ? $_GET['tab'] : '' );
+
 $title = sprintf(
     // translators: %s: The currently displayed tab.
-    __( 'Site Health %s' ),
-    ( isset( $_GET['tab'] ) ? esc_html( $tabs[ $_GET['tab'] ] ) : esc_html( reset( $tabs ) ) )
+    __( 'Site Health - %s' ),
+    ( isset( $tabs[ $current_tab ] ) ? esc_html( $tabs[ $current_tab ] ) : esc_html( reset( $tabs ) ) )
 );
 
@@ -134 +136 @@
                     )
                 ),
-                ( isset( $_GET['tab'] ) && $_GET['tab'] === $slug ? 'active' : '' ),
+                ( $current_tab === $slug ? 'active' : '' ),
                 esc_html( $label )
             );