Changeset 51257

Timestamp:

06/29/2021 12:56:41 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Twenty Seventeen: Avoid JS errors when displaying legacy widgets.

Make sure the $sidebar variable is defined and has at least one entry in the array, before adding the .below-entry-meta class to elements below the entry meta.

Previously, the theme expected sidebar markup to exist on the page if sidebars are defined, but that markup is missing since only the widget itself and headers/footers of the page are loaded in the iframe used to display legacy widgets (widgets added prior to WordPress 5.8).

Props Clorith, Boniu91, desrosj.
Fixes #53512.

File:

• trunk/src/wp-content/themes/twentyseventeen/assets/js/global.js (modified) (1 diff)

trunk/src/wp-content/themes/twentyseventeen/assets/js/global.js

@@ -112 +112 @@
         var sidebarPos, sidebarPosBottom;
 
-        if ( ! $body.hasClass( 'has-sidebar' ) || (
+        if ( ! $body.hasClass( 'has-sidebar' ) ||
+            typeof $sidebar === 'undefined' ||
+            $sidebar.length < 1 || (
             $body.hasClass( 'search' ) ||
             $body.hasClass( 'single-attachment' ) ||