Changeset 51277 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php

Timestamp:

06/30/2021 10:40:21 AM (3 years ago)

Author:

SergeyBiryukov

Message:

REST API: Allow multiple widgets to be deleted in a single batch request.

This resets the WP_Widget::$updated flag when deleting a widget, to avoid blocking all future updates in a request.

Props noisysocks, andraganescu.
Fixes #53557.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php (modified) (4 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php

@@ -290 +290 @@
      * @since 5.8.0
      *
-     * @global array $wp_registered_widget_updates The registered widget update functions.
+     * @global array             $wp_registered_widget_updates The registered widget update functions.
+     * @global WP_Widget_Factory $wp_widget_factory
      *
      * @param WP_REST_Request $request Full details about the request.
@@ -296 +297 @@
      */
     public function delete_item( $request ) {
-        global $wp_registered_widget_updates;
+        global $wp_registered_widget_updates, $wp_widget_factory;
 
         retrieve_widgets();
@@ -344 +345 @@
             $_POST    = $original_post;
             $_REQUEST = $original_request;
+
+            $widget_object = $wp_widget_factory->get_widget_object( $id_base );
+
+            if ( $widget_object ) {
+                /*
+                 * WP_Widget sets `updated = true` after an update to prevent more than one widget
+                 * from being saved per request. This isn't what we want in the REST API, though,
+                 * as we support batch requests.
+                 */
+                $widget_object->updated = false;
+            }
 
             wp_assign_widget_to_sidebar( $widget_id, '' );
@@ -521 +533 @@
             $widget_object->_register_one( $number );
 
-            // WP_Widget sets updated = true after an update to prevent more
-            // than one widget from being saved per request. This isn't what we
-            // want in the REST API, though, as we support batch requests.
+            /*
+             * WP_Widget sets `updated = true` after an update to prevent more than one widget
+             * from being saved per request. This isn't what we want in the REST API, though,
+             * as we support batch requests.
+             */
             $widget_object->updated = false;
         }