Changeset 51277 for trunk/tests/phpunit/tests/rest-api/rest-widgets-controller.php

Timestamp:

06/30/2021 10:40:21 AM (4 years ago)

Author:

SergeyBiryukov

Message:

REST API: Allow multiple widgets to be deleted in a single batch request.

This resets the WP_Widget::$updated flag when deleting a widget, to avoid blocking all future updates in a request.

Props noisysocks, andraganescu.
Fixes #53557.

File:

• trunk/tests/phpunit/tests/rest-api/rest-widgets-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-widgets-controller.php

@@ -166 +166 @@
 
     private function setup_widget( $id_base, $number, $settings ) {
+        $this->setup_widgets( $id_base, array( $number => $settings ) );
+    }
+
+    private function setup_widgets( $id_base, $settings ) {
         global $wp_widget_factory;
 
         $option_name = "widget_$id_base";
-        update_option(
-            $option_name,
-            array(
-                $number => $settings,
-            )
-        );
+        update_option( $option_name, $settings );
 
         $widget_object = $wp_widget_factory->get_widget_object( $id_base );
-        $widget_object->_set( $number );
-        $widget_object->_register_one( $number );
+        foreach ( array_keys( $settings ) as $number ) {
+            $widget_object->_set( $number );
+            $widget_object->_register_one( $number );
+        }
     }
 
@@ -1380 +1381 @@
 
     /**
+     * @ticket 53557
+     */
+    public function test_delete_item_multiple() {
+        $this->setup_widgets(
+            'text',
+            array(
+                2 => array( 'text' => 'Text widget' ),
+                3 => array( 'text' => 'Text widget' ),
+                4 => array( 'text' => 'Text widget' ),
+            )
+        );
+        $this->setup_sidebar(
+            'sidebar-1',
+            array(
+                'name' => 'Test sidebar',
+            ),
+            array( 'text-2', 'text-3', 'text-4' )
+        );
+
+        $request = new WP_REST_Request( 'POST', '/batch/v1' );
+        $request->set_body_params(
+            array(
+                'requests' => array(
+                    array(
+                        'method' => 'DELETE',
+                        'path'   => '/wp/v2/widgets/text-2?force=1',
+                    ),
+                    array(
+                        'method' => 'DELETE',
+                        'path'   => '/wp/v2/widgets/text-3?force=1',
+                    ),
+                    array(
+                        'method' => 'DELETE',
+                        'path'   => '/wp/v2/widgets/text-4?force=1',
+                    ),
+                ),
+            )
+        );
+        $response = rest_do_request( $request );
+
+        $this->assertSame(
+            array(
+                'sidebar-1' => array(),
+            ),
+            wp_get_sidebars_widgets()
+        );
+        $this->assertSame(
+            array(
+                '_multiwidget' => 1,
+            ),
+            get_option( 'widget_text' )
+        );
+    }
+
+    /**
      * The test_prepare_item() method does not exist for sidebar.
      */