Changeset 51285

Timestamp:

06/30/2021 05:43:29 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Remove redundant type casting to array in WP_Query::get_posts().

This brings some consistency with other instances of using get_post_stati() in core.

get_post_stati() always returns an array, so the type casting is not needed.

Follow-up to [13172].

See #53359.

Location:

trunk/src/wp-includes

Files:

• class-wp-query.php (modified) (3 diffs)
• link-template.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-query.php

@@ -2548 +2548 @@
                     $public_statuses = get_post_stati( array( 'public' => true ) );
                     $status_clauses  = array();
-                    foreach ( (array) $public_statuses as $public_status ) {
+                    foreach ( $public_statuses as $public_status ) {
                         $status_clauses[] = "{$wpdb->posts}.post_status = '$public_status'";
                     }
@@ -2561 +2561 @@
                             )
                         );
-                        foreach ( (array) $admin_all_statuses as $admin_all_status ) {
+                        foreach ( $admin_all_statuses as $admin_all_status ) {
                             $type_where .= " OR {$wpdb->posts}.post_status = '$admin_all_status'";
                         }
@@ -2570 +2570 @@
                         $read_private_cap = $queried_post_type_object->cap->read_private_posts;
                         $private_statuses = get_post_stati( array( 'private' => true ) );
-                        foreach ( (array) $private_statuses as $private_status ) {
+                        foreach ( $private_statuses as $private_status ) {
                             $type_where .= current_user_can( $read_private_cap ) ? " \nOR {$wpdb->posts}.post_status = '$private_status'" : " \nOR ({$wpdb->posts}.post_author = $user_id AND {$wpdb->posts}.post_status = '$private_status')";
                         }

trunk/src/wp-includes/link-template.php

@@ -1873 +1873 @@
         $private_states = get_post_stati( array( 'private' => true ) );
         $where         .= " AND ( p.post_status = 'publish'";
-        foreach ( (array) $private_states as $state ) {
+        foreach ( $private_states as $state ) {
             if ( current_user_can( $read_private_cap ) ) {
                 $where .= $wpdb->prepare( ' OR p.post_status = %s', $state );