WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
07/05/2021 05:21:53 PM (4 years ago)
Author:
SergeyBiryukov
Message:

Build/Test Tools: Replace assertInternalType() usage in unit tests.

The assertInternalType() and assertNotInternalType() methods are deprecated in PHPUnit 8 and removed in PHPUnit 9.

While WordPress test suite currently only supports PHPUnit up to 7.5.x, this allows us to switch to newer assertions ahead of adding full support for PHPUnit 8+.

These methods introduced in PHPUnit 7.5 should be used as an alternative:

  • assertIsArray()
  • assertIsBool()
  • assertIsFloat()
  • assertIsInt()
  • assertIsNumeric()
  • assertIsObject()
  • assertIsResource()
  • assertIsString()
  • assertIsScalar()
  • assertIsCallable()
  • assertIsIterable()
  • assertIsNotArray()
  • assertIsNotBool()
  • assertIsNotFloat()
  • assertIsNotInt()
  • assertIsNotNumeric()
  • assertIsNotObject()
  • assertIsNotResource()
  • assertIsNotString()
  • assertIsNotScalar()
  • assertIsNotCallable()
  • assertIsNotIterable()

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods are now added to the WP_UnitTestCase class for PHPUnit < 7.5.

Props pbearne, jrf, dd32, SergeyBiryukov.
Fixes #53491. See #46149.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/general/wpGetArchives.php

    r50339 r51331  
    3232            )
    3333        );
    34         $this->assertInternalType( 'string', $result );
     34        $this->assertIsString( $result );
    3535        $time1 = wp_cache_get( 'last_changed', 'posts' );
    3636        $this->assertNotEmpty( $time1 );
    … …  
    4646            )
    4747        );
    48         $this->assertInternalType( 'string', $result );
     48        $this->assertIsString( $result );
    4949        $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
    5050        $this->assertSame( $num_queries, $wpdb->num_queries );
    … …  
    5858            )
    5959        );
    60         $this->assertInternalType( 'string', $result );
     60        $this->assertIsString( $result );
    6161        $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
    6262        $this->assertSame( $num_queries + 1, $wpdb->num_queries );
    … …  
    7272            )
    7373        );
    74         $this->assertInternalType( 'string', $result );
     74        $this->assertIsString( $result );
    7575        $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
    7676        $this->assertSame( $num_queries, $wpdb->num_queries );
    … …  
    8585            )
    8686        );
    87         $this->assertInternalType( 'string', $result );
     87        $this->assertIsString( $result );
    8888        $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
    8989        $this->assertSame( $num_queries + 1, $wpdb->num_queries );
    … …  
    9898            )
    9999        );
    100         $this->assertInternalType( 'string', $result );
     100        $this->assertIsString( $result );
    101101        $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
    102102        $this->assertSame( $num_queries, $wpdb->num_queries );
    … …  
    109109            )
    110110        );
    111         $this->assertInternalType( 'string', $result );
     111        $this->assertIsString( $result );
    112112        $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
    113113        $this->assertSame( $num_queries + 1, $wpdb->num_queries );
    … …  
    122122            )
    123123        );
    124         $this->assertInternalType( 'string', $result );
     124        $this->assertIsString( $result );
    125125        $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
    126126        $this->assertSame( $num_queries, $wpdb->num_queries );
    … …  
    133133            )
    134134        );
    135         $this->assertInternalType( 'string', $result );
     135        $this->assertIsString( $result );
    136136        $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
    137137        $this->assertSame( $num_queries + 1, $wpdb->num_queries );
    … …  
    146146            )
    147147        );
    148         $this->assertInternalType( 'string', $result );
     148        $this->assertIsString( $result );
    149149        $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
    150150        $this->assertSame( $num_queries, $wpdb->num_queries );
    … …  
    157157            )
    158158        );
    159         $this->assertInternalType( 'string', $result );
     159        $this->assertIsString( $result );
    160160        $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
    161161        $this->assertSame( $num_queries + 1, $wpdb->num_queries );
    … …  
    170170            )
    171171        );
    172         $this->assertInternalType( 'string', $result );
     172        $this->assertIsString( $result );
    173173        $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
    174174        $this->assertSame( $num_queries, $wpdb->num_queries );
Note: See TracChangeset for help on using the changeset viewer.