Changeset 51331 for trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

Timestamp:

07/05/2021 05:21:53 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Build/Test Tools: Replace assertInternalType() usage in unit tests.

The assertInternalType() and assertNotInternalType() methods are deprecated in PHPUnit 8 and removed in PHPUnit 9.

While WordPress test suite currently only supports PHPUnit up to 7.5.x, this allows us to switch to newer assertions ahead of adding full support for PHPUnit 8+.

These methods introduced in PHPUnit 7.5 should be used as an alternative:

• assertIsArray()
• assertIsBool()
• assertIsFloat()
• assertIsInt()
• assertIsNumeric()
• assertIsObject()
• assertIsResource()
• assertIsString()
• assertIsScalar()
• assertIsCallable()
• assertIsIterable()
• assertIsNotArray()
• assertIsNotBool()
• assertIsNotFloat()
• assertIsNotInt()
• assertIsNotNumeric()
• assertIsNotObject()
• assertIsNotResource()
• assertIsNotString()
• assertIsNotScalar()
• assertIsNotCallable()
• assertIsNotIterable()

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods are now added to the WP_UnitTestCase class for PHPUnit < 7.5.

Props pbearne, jrf, dd32, SergeyBiryukov.
Fixes #53491. See #46149.

File:

• trunk/tests/phpunit/tests/rest-api/rest-users-controller.php (modified) (4 diffs)

trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -1212 +1212 @@
 
         if ( is_multisite() ) {
-            $this->assertInternalType( 'array', $data['additional_errors'] );
+            $this->assertIsArray( $data['additional_errors'] );
             $this->assertCount( 1, $data['additional_errors'] );
             $error = $data['additional_errors'][0];
@@ -1218 +1218 @@
             $this->assertSame( 'Usernames can only contain lowercase letters (a-z) and numbers.', $error['message'] );
         } else {
-            $this->assertInternalType( 'array', $data['data']['params'] );
+            $this->assertIsArray( $data['data']['params'] );
             $errors = $data['data']['params'];
-            $this->assertInternalType( 'string', $errors['username'] );
+            $this->assertIsString( $errors['username'] );
             $this->assertSame( 'This username is invalid because it uses illegal characters. Please enter a valid username.', $errors['username'] );
         }
@@ -1258 +1258 @@
 
         $data = $response->get_data();
-        $this->assertInternalType( 'array', $data['data']['params'] );
+        $this->assertIsArray( $data['data']['params'] );
         $errors = $data['data']['params'];
-        $this->assertInternalType( 'string', $errors['username'] );
+        $this->assertIsString( $errors['username'] );
         $this->assertSame( 'Sorry, that username is not allowed.', $errors['username'] );
     }
@@ -1382 +1382 @@
         $this->assertErrorResponse( 'rest_invalid_param', $switched_response, 400 );
         $data = $switched_response->get_data();
-        $this->assertInternalType( 'array', $data['additional_errors'] );
+        $this->assertIsArray( $data['additional_errors'] );
         $this->assertCount( 2, $data['additional_errors'] );
         $errors = $data['additional_errors'];