Changeset 51331 for trunk/tests/phpunit/tests/xmlrpc/wp/getPostType.php

Timestamp:

07/05/2021 05:21:53 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Build/Test Tools: Replace assertInternalType() usage in unit tests.

The assertInternalType() and assertNotInternalType() methods are deprecated in PHPUnit 8 and removed in PHPUnit 9.

While WordPress test suite currently only supports PHPUnit up to 7.5.x, this allows us to switch to newer assertions ahead of adding full support for PHPUnit 8+.

These methods introduced in PHPUnit 7.5 should be used as an alternative:

• assertIsArray()
• assertIsBool()
• assertIsFloat()
• assertIsInt()
• assertIsNumeric()
• assertIsObject()
• assertIsResource()
• assertIsString()
• assertIsScalar()
• assertIsCallable()
• assertIsIterable()
• assertIsNotArray()
• assertIsNotBool()
• assertIsNotFloat()
• assertIsNotInt()
• assertIsNotNumeric()
• assertIsNotObject()
• assertIsNotResource()
• assertIsNotString()
• assertIsNotScalar()
• assertIsNotCallable()
• assertIsNotIterable()

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods are now added to the WP_UnitTestCase class for PHPUnit < 7.5.

Props pbearne, jrf, dd32, SergeyBiryukov.
Fixes #53491. See #46149.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getPostType.php (modified) (1 diff)

trunk/tests/phpunit/tests/xmlrpc/wp/getPostType.php

@@ -60 +60 @@
 
         // Check data types.
-        $this->assertInternalType( 'string', $result['name'] );
-        $this->assertInternalType( 'string', $result['label'] );
-        $this->assertInternalType( 'bool', $result['hierarchical'] );
-        $this->assertInternalType( 'bool', $result['public'] );
-        $this->assertInternalType( 'bool', $result['_builtin'] );
-        $this->assertInternalType( 'bool', $result['map_meta_cap'] );
-        $this->assertInternalType( 'bool', $result['has_archive'] );
-        $this->assertInternalType( 'bool', $result['show_ui'] );
-        $this->assertInternalType( 'int', $result['menu_position'] );
-        $this->assertInternalType( 'string', $result['menu_icon'] );
-        $this->assertInternalType( 'array', $result['labels'] );
-        $this->assertInternalType( 'array', $result['cap'] );
-        $this->assertInternalType( 'array', $result['taxonomies'] );
-        $this->assertInternalType( 'array', $result['supports'] );
+        $this->assertIsString( $result['name'] );
+        $this->assertIsString( $result['label'] );
+        $this->assertIsBool( $result['hierarchical'] );
+        $this->assertIsBool( $result['public'] );
+        $this->assertIsBool( $result['_builtin'] );
+        $this->assertIsBool( $result['map_meta_cap'] );
+        $this->assertIsBool( $result['has_archive'] );
+        $this->assertIsBool( $result['show_ui'] );
+        $this->assertIsInt( $result['menu_position'] );
+        $this->assertIsString( $result['menu_icon'] );
+        $this->assertIsArray( $result['labels'] );
+        $this->assertIsArray( $result['cap'] );
+        $this->assertIsArray( $result['taxonomies'] );
+        $this->assertIsArray( $result['supports'] );
 
         // Check label data types.
-        $this->assertInternalType( 'string', $result['labels']['name'] );
-        $this->assertInternalType( 'string', $result['labels']['singular_name'] );
-        $this->assertInternalType( 'string', $result['labels']['add_new'] );
-        $this->assertInternalType( 'string', $result['labels']['add_new_item'] );
-        $this->assertInternalType( 'string', $result['labels']['edit_item'] );
-        $this->assertInternalType( 'string', $result['labels']['new_item'] );
-        $this->assertInternalType( 'string', $result['labels']['view_item'] );
-        $this->assertInternalType( 'string', $result['labels']['search_items'] );
-        $this->assertInternalType( 'string', $result['labels']['not_found'] );
-        $this->assertInternalType( 'string', $result['labels']['not_found_in_trash'] );
-        $this->assertInternalType( 'string', $result['labels']['parent_item_colon'] );
-        $this->assertInternalType( 'string', $result['labels']['all_items'] );
-        $this->assertInternalType( 'string', $result['labels']['menu_name'] );
-        $this->assertInternalType( 'string', $result['labels']['name_admin_bar'] );
+        $this->assertIsString( $result['labels']['name'] );
+        $this->assertIsString( $result['labels']['singular_name'] );
+        $this->assertIsString( $result['labels']['add_new'] );
+        $this->assertIsString( $result['labels']['add_new_item'] );
+        $this->assertIsString( $result['labels']['edit_item'] );
+        $this->assertIsString( $result['labels']['new_item'] );
+        $this->assertIsString( $result['labels']['view_item'] );
+        $this->assertIsString( $result['labels']['search_items'] );
+        $this->assertIsString( $result['labels']['not_found'] );
+        $this->assertIsString( $result['labels']['not_found_in_trash'] );
+        $this->assertIsString( $result['labels']['parent_item_colon'] );
+        $this->assertIsString( $result['labels']['all_items'] );
+        $this->assertIsString( $result['labels']['menu_name'] );
+        $this->assertIsString( $result['labels']['name_admin_bar'] );
 
         // Check cap data types.
-        $this->assertInternalType( 'string', $result['cap']['edit_post'] );
-        $this->assertInternalType( 'string', $result['cap']['read_post'] );
-        $this->assertInternalType( 'string', $result['cap']['delete_post'] );
-        $this->assertInternalType( 'string', $result['cap']['edit_posts'] );
-        $this->assertInternalType( 'string', $result['cap']['edit_others_posts'] );
-        $this->assertInternalType( 'string', $result['cap']['publish_posts'] );
-        $this->assertInternalType( 'string', $result['cap']['read_private_posts'] );
-        $this->assertInternalType( 'string', $result['cap']['read'] );
-        $this->assertInternalType( 'string', $result['cap']['delete_posts'] );
-        $this->assertInternalType( 'string', $result['cap']['delete_private_posts'] );
-        $this->assertInternalType( 'string', $result['cap']['delete_published_posts'] );
-        $this->assertInternalType( 'string', $result['cap']['delete_others_posts'] );
-        $this->assertInternalType( 'string', $result['cap']['edit_private_posts'] );
-        $this->assertInternalType( 'string', $result['cap']['edit_published_posts'] );
+        $this->assertIsString( $result['cap']['edit_post'] );
+        $this->assertIsString( $result['cap']['read_post'] );
+        $this->assertIsString( $result['cap']['delete_post'] );
+        $this->assertIsString( $result['cap']['edit_posts'] );
+        $this->assertIsString( $result['cap']['edit_others_posts'] );
+        $this->assertIsString( $result['cap']['publish_posts'] );
+        $this->assertIsString( $result['cap']['read_private_posts'] );
+        $this->assertIsString( $result['cap']['read'] );
+        $this->assertIsString( $result['cap']['delete_posts'] );
+        $this->assertIsString( $result['cap']['delete_private_posts'] );
+        $this->assertIsString( $result['cap']['delete_published_posts'] );
+        $this->assertIsString( $result['cap']['delete_others_posts'] );
+        $this->assertIsString( $result['cap']['edit_private_posts'] );
+        $this->assertIsString( $result['cap']['edit_published_posts'] );
 
         // Check taxonomy data types.
         foreach ( $result['taxonomies'] as $taxonomy ) {
-            $this->assertInternalType( 'string', $taxonomy );
+            $this->assertIsString( $taxonomy );
         }
 
         // Check support data types.
         foreach ( $result['supports'] as $key => $value ) {
-            $this->assertInternalType( 'string', $key );
-            $this->assertInternalType( 'bool', $value );
+            $this->assertIsString( $key );
+            $this->assertIsBool( $value );
         }