Changeset 51335 for trunk/tests/phpunit/tests/theme.php

Timestamp:

07/06/2021 12:25:53 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( is_array( ... ) ) with assertIsArray() to use native PHPUnit functionality.

Follow-up to [51331].

See #53363.

File:

• trunk/tests/phpunit/tests/theme.php (modified) (2 diffs)

trunk/tests/phpunit/tests/theme.php

@@ -146 +146 @@
 
             // Template files should all exist.
-            $this->assertTrue( is_array( $theme['Template Files'] ) );
-            $this->assertTrue( count( $theme['Template Files'] ) > 0 );
+            $this->assertIsArray( $theme['Template Files'] );
+            $this->assertNotEmpty( $theme['Template Files'] );
             foreach ( $theme['Template Files'] as $file ) {
                 $this->assertTrue( is_file( $dir . $file ) );
@@ -154 +154 @@
 
             // CSS files should all exist.
-            $this->assertTrue( is_array( $theme['Stylesheet Files'] ) );
-            $this->assertTrue( count( $theme['Stylesheet Files'] ) > 0 );
+            $this->assertIsArray( $theme['Stylesheet Files'] );
+            $this->assertNotEmpty( $theme['Stylesheet Files'] );
             foreach ( $theme['Stylesheet Files'] as $file ) {
                 $this->assertTrue( is_file( $dir . $file ) );