Changeset 51337

Timestamp:

07/06/2021 12:31:19 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( is_object( ... ) ) with assertIsObject() to use native PHPUnit functionality.

Follow-up to [51331], [51335].

See #53363.

Location:

trunk/tests/phpunit/tests

Files:

• post/nav-menu.php (modified) (1 diff)
• taxonomy.php (modified) (2 diffs)

trunk/tests/phpunit/tests/post/nav-menu.php

@@ -552 +552 @@
          */
         function _confirm_nav_menu_item_args_object( $args ) {
-                $this->assertTrue( is_object( $args ) );
+                $this->assertIsObject( $args );
                 return $args;
         }
 
         function _confirm_second_param_args_object( $ignored_1, $args ) {
-                $this->assertTrue( is_object( $args ) );
+                $this->assertIsObject( $args );
                 return $ignored_1;
         }
 
         function _confirm_third_param_args_object( $ignored_1, $ignored_2, $args ) {
-                $this->assertTrue( is_object( $args ) );
+                $this->assertIsObject( $args );
                 return $ignored_1;
         }
 
         function _confirm_forth_param_args_object( $ignored_1, $ignored_2, $ignored_3, $args ) {
-                $this->assertTrue( is_object( $args ) );
+                $this->assertIsObject( $args );
                 return $ignored_1;
         }

trunk/tests/phpunit/tests/taxonomy.php

@@ -28 +28 @@
                         $tax = get_taxonomy( $taxonomy );
                         // Should return an object with the correct taxonomy object type.
-                        $this->assertTrue( is_object( $tax ) );
+                        $this->assertIsObject( $tax );
                         $this->assertIsArray( $tax->object_type );
                         $this->assertSame( array( 'post' ), $tax->object_type );
@@ -110 +110 @@
                         $tax = get_taxonomy( $taxonomy );
                         // Should return an object with the correct taxonomy object type.
-                        $this->assertTrue( is_object( $tax ) );
+                        $this->assertIsObject( $tax );
                         $this->assertIsArray( $tax->object_type );
                         $this->assertSame( array( 'link' ), $tax->object_type );