Changeset 5135

Timestamp:

03/29/2007 01:39:05 AM (19 years ago)

Author:

rob1n

Message:

Speed (wp_)list_authors by consolidating some queries. Props graeme. fixes #1659

File:

• trunk/wp-includes/author-template.php (modified) (2 diffs)

trunk/wp-includes/author-template.php

@@ -174 +174 @@
 
 function wp_list_authors($args = '') {
+        global $wpdb;
+        
         if ( is_array($args) )
                 $r = &$args;
@@ -183 +185 @@
         $r = array_merge($defaults, $r);
         extract($r);
-
-        global $wpdb;
+        
         // TODO:  Move select to get_authors().
-        $query = "SELECT ID, user_nicename from $wpdb->users " . ($exclude_admin ? "WHERE user_login <> 'admin' " : '') . "ORDER BY display_name";
-        $authors = $wpdb->get_results($query);
+        $authors = $wpdb->get_results("SELECT ID, user_nicename from $wpdb->users " . ($exclude_admin ? "WHERE user_login <> 'admin' " : '') . "ORDER BY display_name");
+        
+        $author_count = array();
+        foreach ((array) $wpdb->get_results("SELECT DISTINCT post_author, COUNT(ID) AS count FROM $wpdb->posts WHERE post_status = 'publish' GROUP BY post_author") as $row) {
+                $author_count[$row->post_author] = $row->count;
+        }
 
         foreach ( (array) $authors as $author ) {
                 $author = get_userdata( $author->ID );
-                $posts = get_usernumposts($author->ID);
+                $posts = (isset($author_count[$author->ID])) ? $author_count[$author->ID] : 0;
                 $name = $author->nickname;