Changeset 51350 for branches/5.8

Timestamp:

07/06/2021 03:55:02 PM (5 years ago)

Author:

desrosj

Message:

REST API: Add the $request parameter to methods checking permissions.

This adds the $request parameter to the permissions_check() methods within WP_REST_Widgets_Controller and adds $request as an allowed parameter to the permissions_check() method within WP_REST_Templates_Controller.

Even when this parameter is not used by default, it should be implemented to support the class being extended and the method overridden.

Props johnbillion, timothyblynjacobs.
Merges [51349] to the 5.8 branch.
Fixes #53593.

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php (modified) (1 diff)
• src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php (modified) (6 diffs)

branches/5.8/src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php

@@ -110 +110 @@
          * @since 5.8.0
          *
+         * @param WP_REST_Request $request Full details about the request.
          * @return true|WP_Error True if the request has read access, WP_Error object otherwise.
          */
-        protected function permissions_check() {
+        protected function permissions_check( $request ) {
                 // Verify if the current user has edit_theme_options capability.
                 // This capability is required to edit/view/delete templates.

branches/5.8/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php

@@ -98 +98 @@
          */
         public function get_items_permissions_check( $request ) {
-                return $this->permissions_check();
+                return $this->permissions_check( $request );
         }
 
@@ -140 +140 @@
          */
         public function get_item_permissions_check( $request ) {
-                return $this->permissions_check();
+                return $this->permissions_check( $request );
         }
 
@@ -177 +177 @@
          */
         public function create_item_permissions_check( $request ) {
-                return $this->permissions_check();
+                return $this->permissions_check( $request );
         }
 
@@ -221 +221 @@
          */
         public function update_item_permissions_check( $request ) {
-                return $this->permissions_check();
+                return $this->permissions_check( $request );
         }
 
@@ -284 +284 @@
          */
         public function delete_item_permissions_check( $request ) {
-                return $this->permissions_check();
+                return $this->permissions_check( $request );
         }
 
@@ -399 +399 @@
          * @since 5.8.0
          *
+         * @param WP_REST_Request $request Full details about the request.
          * @return true|WP_Error
          */
-        protected function permissions_check() {
+        protected function permissions_check( $request ) {
                 if ( ! current_user_can( 'edit_theme_options' ) ) {
                         return new WP_Error(