Changeset 51355 for trunk/.github/workflows/php-compatibility.yml

Timestamp:

07/06/2021 06:36:46 PM (4 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Add assertions to ensure version-controlled files are not modified during CI, and fix the grunt clean command.

Some tests and some commands that run during the build steps modify files that are under version control. This adds assertions to ensure that these files don't remain in a modified state after the test runs on CI.

This also fixes the grunt clean command which erroneously deletes script-loader-packages.php. This file is re-populated during the build, but deleting it during the clean is undesirable.

Fixes #53606

File:

• trunk/.github/workflows/php-compatibility.yml (modified) (2 diffs)

trunk/.github/workflows/php-compatibility.yml

@@ -50 +50 @@
   # - Logs PHP_CodeSniffer debug information.
   # - Runs the PHP compatibility tests.
+  # - Ensures version-controlled files are not modified or deleted.
   # - todo: Configure Slack notifications for failing scans.
   php-comatibility:
@@ -85 +86 @@
       - name: Run PHP compatibility tests
         run: phpcs --standard=phpcompat.xml.dist -q --report=checkstyle | cs2pr
+
+      - name: Ensure version-controlled files are not modified or deleted
+        run: git diff --exit-code