Changeset 51357 for branches/5.8/.github/workflows/coding-standards.yml

Timestamp:

07/06/2021 07:12:23 PM (5 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Add assertions to ensure version-controlled files are not modified during CI, and fix the grunt clean command.

Some tests and some commands that run during the build steps modify files that are under version control. This adds assertions to ensure that these files don't remain in a modified state after the test runs on CI.

This also fixes the grunt clean command which erroneously deletes script-loader-packages.php. This file is re-populated during the build, but deleting it during the clean is undesirable.

Merges [51355] to the 5.8 branch.

Fixes #53606

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• .github/workflows/coding-standards.yml (modified) (4 diffs)

branches/5.8/.github/workflows/coding-standards.yml

@@ -56 +56 @@
   # - Runs PHPCS on the full codebase with warnings suppressed.
   # - Runs PHPCS on the `tests` directory without warnings suppressed.
+  # - Ensures version-controlled files are not modified or deleted.
   # - todo: Configure Slack notifications for failing scans.
   phpcs:
@@ -95 +96 @@
         run: phpcs tests -q --report=checkstyle | cs2pr
 
+      - name: Ensure version-controlled files are not modified during the tests
+        run: git diff --exit-code
+
   # Runs the JavaScript coding standards checks.
   #
@@ -107 +111 @@
   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
   # - Run the WordPress JSHint checks.
+  # - Ensures version-controlled files are not modified or deleted.
   # - todo: Configure Slack notifications for failing tests.
   jshint:
@@ -150 +155 @@
       - name: Run JSHint
         run: npm run grunt jshint
+
+      - name: Ensure version-controlled files are not modified or deleted
+        run: git diff --exit-code