Changeset 51357 for branches/5.8/.github/workflows/test-coverage.yml

Timestamp:

07/06/2021 07:12:23 PM (4 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Add assertions to ensure version-controlled files are not modified during CI, and fix the grunt clean command.

Some tests and some commands that run during the build steps modify files that are under version control. This adds assertions to ensure that these files don't remain in a modified state after the test runs on CI.

This also fixes the grunt clean command which erroneously deletes script-loader-packages.php. This file is re-populated during the build, but deleting it during the clean is undesirable.

Merges [51355] to the 5.8 branch.

Fixes #53606

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• .github/workflows/test-coverage.yml (modified) (3 diffs)

branches/5.8/.github/workflows/test-coverage.yml

@@ -45 +45 @@
   # - Install WordPress within the Docker container.
   # - Run the PHPUnit tests as a single site.
+  # - Ensures version-controlled files are not modified or deleted.
   # - Upload the single site code coverage report to Codecov.io.
   # - Run the PHPUnit tests as a multisite.
+  # - Ensures version-controlled files are not modified or deleted.
   # - Upload the multisite code coverage report to Codecov.io.
   test-coverage-report:
@@ -131 +133 @@
         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c phpunit.xml.dist --coverage-clover wp-code-coverage-single-clover-${{ github.sha }}.xml
 
+      - name: Ensure version-controlled files are not modified during the tests
+        run: git diff --exit-code
+
       - name: Upload single site report to Codecov
         if: ${{ ! matrix.multisite }}
@@ -142 +147 @@
         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c tests/phpunit/multisite.xml --coverage-clover wp-code-coverage-multisite-clover-${{ github.sha }}.xml
 
+      - name: Ensure version-controlled files are not modified during the tests
+        run: git diff --exit-code
+
       - name: Upload multisite report to Codecov
         if: ${{ matrix.multisite }}