Changeset 51357 for branches/5.8/.github/workflows/test-npm.yml

Timestamp:

07/06/2021 07:12:23 PM (5 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Add assertions to ensure version-controlled files are not modified during CI, and fix the grunt clean command.

Some tests and some commands that run during the build steps modify files that are under version control. This adds assertions to ensure that these files don't remain in a modified state after the test runs on CI.

This also fixes the grunt clean command which erroneously deletes script-loader-packages.php. This file is re-populated during the build, but deleting it during the clean is undesirable.

Merges [51355] to the 5.8 branch.

Fixes #53606

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• .github/workflows/test-npm.yml (modified) (6 diffs)

branches/5.8/.github/workflows/test-npm.yml

@@ -47 +47 @@
   # - Builds WordPress to run from the `build` directory.
   # - Cleans up after building WordPress to the `build` directory.
+  # - Ensures version-controlled files are not modified or deleted.
   # - Builds WordPress to run from the `src` directory.
   # - Cleans up after building WordPress to the `src` directory.
+  # - Ensures version-controlled files are not modified or deleted.
   test-npm:
     name: Test NPM on ${{ matrix.os }}
@@ -103 +105 @@
         run: npm run grunt clean
 
+      - name: Ensure version-controlled files are not modified or deleted during building and cleaning
+        run: git diff --exit-code
+
       - name: Build WordPress in /src
         run: npm run build:dev
@@ -108 +113 @@
       - name: Clean after building in /src
         run: npm run grunt clean -- --dev
+
+      - name: Ensure version-controlled files are not modified or deleted during building and cleaning
+        run: git diff --exit-code
 
   # Verifies that installing NPM dependencies and building WordPress works as expected on MacOS.
@@ -121 +129 @@
   # - Builds WordPress to run from the `build` directory.
   # - Cleans up after building WordPress to the `build` directory.
+  # - Ensures version-controlled files are not modified or deleted.
   # - Builds WordPress to run from the `src` directory.
   # - Cleans up after building WordPress to the `src` directory.
+  # - Ensures version-controlled files are not modified or deleted.
   test-npm-macos:
     name: Test NPM on MacOS
@@ -160 +170 @@
         run: npm run grunt clean
 
+      - name: Ensure version-controlled files are not modified or deleted during building and cleaning
+        run: git diff --exit-code
+
       - name: Build WordPress in /src
         run: npm run build:dev
@@ -165 +178 @@
       - name: Clean after building in /src
         run: npm run grunt clean -- --dev
+
+      - name: Ensure version-controlled files are not modified or deleted during building and cleaning
+        run: git diff --exit-code